[Mlir-commits] [mlir] [mlir][transform] LISH: Add transform op (PR #70630)

[Oleksandr Alex Zinenko]

================
@@ -691,6 +691,65 @@ def GetTypeOp : TransformDialectOp<"get_type",
                        "functional-type(operands, results)";
 }
 
+def HoistLoopInvariantSubsetsOp
----------------
ftynse wrote:

I'm not sure I fully endorse this op living in the "core" transform dialect. I understand that it is interface-based, so it doesn't belong with any specific dialect, but that doesn't sound like a great way to group things. IMO, the "core" part should mostly contain generic constructs like `foreach` and `apply_patterns` that don't depend even on interfaces. For the rest, we can have TD extensions living within the TD itself, we already do for PDL patterns. Though I can't come up with a good name. WDYT?

https://github.com/llvm/llvm-project/pull/70630