[Mlir-commits] [mlir] [MLIR][LLVM] Deprecate typed pointer operation builder (PR #70576)

Christian Ulmann llvmlistbot at llvm.org
Sun Oct 29 01:40:08 PDT 2023


Dinistro wrote:

> Do you think its worth formulating some of the deprecation messages in an instructive manner? E.g. for the load op something like "support of typed pointer is deprecated, use builder with explicit result type instead".
> 
> On the other hand, I'd suspect users to just check what non-deprecated builders are available instead probably so this might just be wasted effort.
> 
> LGTM otherwise.

I would assume that people will just go ahead and check the other builders. The typed vs. opaque pointer discussion is ongoing for a while now, and I suspect that most people will figure out what's going on. Given that we aim to write a PSA for the general removal, this should be enough, I suppose.

I'm going ahead an merge this now. If it turns out that expanding the message is something necessary, we can still do so in a followup. 

https://github.com/llvm/llvm-project/pull/70576


More information about the Mlir-commits mailing list