[Mlir-commits] [mlir] [mlir][spirv] Add support for VectorAnyINTEL capability (PR #68034)

Lei Zhang llvmlistbot at llvm.org
Sat Oct 28 22:33:02 PDT 2023


https://github.com/antiagainst requested changes to this pull request.

Thanks for the contribution! I'm okay of extending the SPIR-V dialect to support VectorAnyINTEL. I see actually you've putting quite some efforts to make sure details are correct; really appreciate that! Though we still need to be quite careful here given this is touching some very fundamental expectations and validations. So please bear with me for maybe multiple rounds of reviews. :) 

I left a few comments but not going through stuff extensively yet. Can we actually sequence this as multiple patches for easy reviews? E.g.,

1. Relax the IR vector type requirements, but as @kuar said, move the validation to `spirv.module` op, where we know the list of final capablities. We can then go through all ops and see their types and validate.
2. Then do the conversion side changes. 

https://github.com/llvm/llvm-project/pull/68034


More information about the Mlir-commits mailing list