[Mlir-commits] [mlir] [NFC] Make AggregateOpInterface part of mlir:: instead of linalg:: (PR #70089)

Mehdi Amini llvmlistbot at llvm.org
Fri Oct 27 15:49:46 PDT 2023


joker-eph wrote:

> > I don't think this is ready to proceed.
> 
> could you give some feedback, then how to proceed then. This interface is not being added. It is in the Linalg dialect (where it really does not belong). So this PR is only moving it.

I thought you concluded in the thread above where you wrote:

>  I am happy to go with one of two options
> 1. We keep the interface in Linalg...
> 2. We move the interface out of core into IREE... Since there we have more control of which ops implement the interface, we can prevent unintended uses of it.

I'm confused by your comment there?



https://github.com/llvm/llvm-project/pull/70089


More information about the Mlir-commits mailing list