[Mlir-commits] [mlir] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

Jakub Kuderski llvmlistbot at llvm.org
Fri Oct 27 07:41:04 PDT 2023


================
@@ -578,7 +578,10 @@ def ConvertGPUToSPIRV : Pass<"convert-gpu-to-spirv", "ModuleOp"> {
     to control the set and binding if wanted.
   }];
   let constructor = "mlir::createConvertGPUToSPIRVPass()";
-  let dependentDialects = ["spirv::SPIRVDialect"];
+  let dependentDialects = [
+    "spirv::SPIRVDialect",
+    "func::FuncDialect",
----------------
kuhar wrote:

nit: IIRC we try to keep these sorted alphabetically
```suggestion
    "func::FuncDialect",
    "spirv::SPIRVDialect",
```

https://github.com/llvm/llvm-project/pull/69941


More information about the Mlir-commits mailing list