[Mlir-commits] [mlir] [DRAFT] Generalize expand_shape to take shape as explicit input (PR #69267)

[Gaurav Shukla]

================
@@ -109,9 +109,8 @@ SmallVector<OpFoldResult> getMixedValues(ArrayRef<int64_t> staticValues,
 /// Decompose a vector of mixed static or dynamic values into the
 /// corresponding pair of arrays. This is the inverse function of
 /// `getMixedValues`.
-std::pair<ArrayAttr, SmallVector<Value>>
-decomposeMixedValues(Builder &b,
-                     const SmallVectorImpl<OpFoldResult> &mixedValues);
+std::pair<SmallVector<int64_t>, SmallVector<Value>>
----------------
Shukla-Gaurav wrote:

Yeah, it seems this patch does not necessarily require this method. If the helper build method seems fine(mentioned in the next comment), I will address this comment together with the next one.

https://github.com/llvm/llvm-project/pull/69267