[Mlir-commits] [mlir] [mlir][ArmSME] Support lowering masked vector.outerproduct ops to SME (PR #69604)

[Andrzej Warzyński]

https://github.com/banach-space commented:

This is obviously great :) I've made a few suggestions and raised a few questions, but nothing major.

I do think that this could be split into two patches though:
* introduce `arm_sme.outerproduct` (and rewire the lowering for `vector.outerproduct`,
* add support for masking.

I'm not going to push for that, as Diego has already accepted and in general this very well crafted - the noise is not too bad. Just a note for our futures selves :)

https://github.com/llvm/llvm-project/pull/69604