[Mlir-commits] [mlir] [TOSA] Add StatefulOps to TOSA Dialect (PR #66843)

[Adrian Kuegel]

================
@@ -398,8 +404,12 @@ struct TosaValidation : public tosa::impl::TosaValidationBase<TosaValidation> {
     }
   }
 
+  bool CheckVariable(Operation *op);
+  bool CheckVariableReadOrWrite(Operation *op);
+
   SmallVector<std::function<LogicalResult(Operation *)>> const_checkers;
   tosa_level_t tosa_level;
+  std::unordered_map<std::string, mlir::Type> variables_map;
----------------
akuegel wrote:

I guess there was a misunderstanding here, now the code uses StringAttr*, but I think @joker-eph meant to use StringAttr. With --config=asan there are now failing tests from the newly added tests, I think we cannot rely on the address being the same if the string inside the StringAttr is the same.

https://github.com/llvm/llvm-project/pull/66843