[Mlir-commits] [mlir] [mlir][vector] Enable transfer op hoisting with dynamic indices (PR #68500)

Andrzej WarzyƄski llvmlistbot at llvm.org
Thu Oct 12 08:18:20 PDT 2023


https://github.com/banach-space approved this pull request.

Hi @antiagainst , I am sorry that #66930 has caused you trouble. These changes make sense to me, so approving as is. But please wait a few more days before landing - it would be good if @nicolasvasilache and/or @matthias-springer could also take a look. They are much more familiar with this code than I am.  

Btw, it seems that `testDynamicValueUsingBounds` is set to `true` in most places. Perhaps, instead, that should be controllable through the transform op? (i.e. `hoist_redundant_vector_transfers`)

https://github.com/llvm/llvm-project/pull/68500


More information about the Mlir-commits mailing list