[Mlir-commits] [mlir] [mlir][index][spirv] Add conversion for index to spirv (PR #68085)

Jakub Kuderski llvmlistbot at llvm.org
Mon Oct 9 17:48:26 PDT 2023


================
@@ -693,6 +693,8 @@ SPIRVTypeConverter::SPIRVTypeConverter(spirv::TargetEnvAttr targetAttr,
   addConversion([this](IndexType /*indexType*/) { return getIndexType(); });
 
   addConversion([this](IntegerType intType) -> std::optional<Type> {
+    if (!this->options.convertIntAsScalar)
----------------
kuhar wrote:

Can't we resolve this by adding a module with the right target env around the code in test cases? Have you checked where the `const spirv::TargetEnv &targetEnv` parameter in comes from in `convertScalarType`?

https://github.com/llvm/llvm-project/pull/68085


More information about the Mlir-commits mailing list