[Mlir-commits] [mlir] [mlir][index][spirv] Add conversion for index to spirv (PR #68085)

Jakub Kuderski llvmlistbot at llvm.org
Mon Oct 9 17:48:26 PDT 2023


https://github.com/kuhar commented:

Looks solid, I'd just like to confirm if we need the hack for scalar types.

Also, is type converter allowed to fail in `getIndexType()`? If we yes, we are missing nullptr checks for failed index queries. My guess is that for any reasonable type converter for SPIR-V, i32 should be always available.

https://github.com/llvm/llvm-project/pull/68085


More information about the Mlir-commits mailing list