[Mlir-commits] [mlir] [mlir][sparse] Print new syntax (PR #68130)

Aart Bik llvmlistbot at llvm.org
Wed Oct 4 13:01:20 PDT 2023


================
@@ -422,6 +422,14 @@ def SparseTensorEncodingAttr : SparseTensor_Attr<"SparseTensorEncoding",
     std::optional<uint64_t> getStaticLvlSliceOffset(::mlir::sparse_tensor::Level lvl) const;
     std::optional<uint64_t> getStaticLvlSliceSize(::mlir::sparse_tensor::Level lvl) const;
     std::optional<uint64_t> getStaticLvlSliceStride(::mlir::sparse_tensor::Level lvl) const;
+
+    //
+    // Printing methods.
+    //
+
+    void printSymbol(AffineMap &map, AsmPrinter &printer) const;
----------------
aartbik wrote:

one last nit: can we make these plural, as in printSymbols, printDimensions, printLevels
other than that go to go!

https://github.com/llvm/llvm-project/pull/68130


More information about the Mlir-commits mailing list