[Mlir-commits] [mlir] Revert "[mlir] Fix a warning" (PR #73640)

Alexander Batashev llvmlistbot at llvm.org
Tue Nov 28 04:19:41 PST 2023


https://github.com/alexbatashev created https://github.com/llvm/llvm-project/pull/73640

Revert patch 6318dd82732c583fcfa12fe5b8d837e048dbb571 "[mlir] Fix a warning"

Template ID is not allowed in destructor names starting with C++ 20: https://eel.is/c++draft/diff.cpp17.class#2

>From a782b06ccc41bc73aaf7c7891983955b55ec1d69 Mon Sep 17 00:00:00 2001
From: Alexander Batashev <alexbatashev at outlook.com>
Date: Tue, 28 Nov 2023 15:18:45 +0300
Subject: [PATCH] Revert "[mlir] Fix a warning"

Revert patch 6318dd82732c583fcfa12fe5b8d837e048dbb571 "[mlir] Fix a warning"

Template ID is not allowed in destructor names starting with C++ 20: https://eel.is/c++draft/diff.cpp17.class#2
---
 mlir/lib/Pass/PassRegistry.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/lib/Pass/PassRegistry.cpp b/mlir/lib/Pass/PassRegistry.cpp
index b0c314369190a40..35ac4b8fd280eab 100644
--- a/mlir/lib/Pass/PassRegistry.cpp
+++ b/mlir/lib/Pass/PassRegistry.cpp
@@ -373,7 +373,7 @@ llvm::cl::OptionValue<OpPassManager>::operator=(
   return *this;
 }
 
-llvm::cl::OptionValue<OpPassManager>::~OptionValue<OpPassManager>() = default;
+llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;
 
 void llvm::cl::OptionValue<OpPassManager>::setValue(
     const OpPassManager &newValue) {



More information about the Mlir-commits mailing list