[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Christian Ulmann]

================
@@ -23,15 +23,24 @@
 namespace mlir {
 namespace LLVM {
 
-/// This class represents the base attribute for all debug info attributes.
-class DINodeAttr : public Attribute {
+/// This class represents the base attribute for all metadata attributes.
+class MDNodeAttr : public Attribute {
----------------
Dinistro wrote:

I do understand both sides of this argument. Reflecting LLVM's class hierarchy seems natural and helpful. On the other hand, there are tons of metadata nodes that we model and non of them would inherit from this.
I suggest to maybe consider adding this in a followup, instead of this revision.

https://github.com/llvm/llvm-project/pull/73367