[Mlir-commits] [mlir] [MLIR][Vector] Refactor tests for contract -> OP transforms (PR #73217)

Andrzej WarzyƄski llvmlistbot at llvm.org
Fri Nov 24 08:46:43 PST 2023


banach-space wrote:

> To make review easier in future think it'd be nice if each of:
> 
> * duplicate tests are removed,
> * missing cases for scalable vectors are added,
> * names of LIT variables and operation traits are unified.
> 
> Were separate commits in the PR, even though the PR will be squashed into a single commit :)

Haha, that was half-expected :) Let me do it as separate PRs - I am yet to get used to having separate commits as meaningful chunks for work (sorry, old habits).

Abandoning in favour of https://github.com/llvm/llvm-project/pull/73348 and follow-ups therein. 

https://github.com/llvm/llvm-project/pull/73217


More information about the Mlir-commits mailing list