[Mlir-commits] [mlir] Revert "[mlir][vector] Move transpose with unit-dim to shape_cast pattern (#72493)" (PR #72918)

[Quinn Dawkins]

https://github.com/qedawkins approved this pull request.

+1, I'm not sure this is well suited for a canonicalization. `vector.transpose` has an additional guarantee that the source and result vector ranks are the same, as well as tells how to relate dimensions between the source and the result. I see that as useful information even when all of the transposed dimensions are unit dims. `shape_cast` does not have that same guarantee and might require analysis to recover the semantic meaning of the shape_cast in some cases (not that I have such a case on hand, but shape casts like this aren't easy to handle in SPIR-V).

https://github.com/llvm/llvm-project/pull/72918