[Mlir-commits] [mlir] 962bf00 - Apply clang-tidy fixes for performance-unnecessary-value-param in IRAttributes.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Sat Nov 18 15:38:32 PST 2023


Author: Mehdi Amini
Date: 2023-11-18T15:38:21-08:00
New Revision: 962bf002fec2672ea61de49cfb945ff031830819

URL: https://github.com/llvm/llvm-project/commit/962bf002fec2672ea61de49cfb945ff031830819
DIFF: https://github.com/llvm/llvm-project/commit/962bf002fec2672ea61de49cfb945ff031830819.diff

LOG: Apply clang-tidy fixes for performance-unnecessary-value-param in IRAttributes.cpp (NFC)

Added: 
    

Modified: 
    mlir/lib/Bindings/Python/IRAttributes.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Bindings/Python/IRAttributes.cpp b/mlir/lib/Bindings/Python/IRAttributes.cpp
index 94fa2527e40891e..dda2003ba0375a9 100644
--- a/mlir/lib/Bindings/Python/IRAttributes.cpp
+++ b/mlir/lib/Bindings/Python/IRAttributes.cpp
@@ -1032,7 +1032,7 @@ class PyDenseResourceElementsAttribute
   using PyConcreteAttribute::PyConcreteAttribute;
 
   static PyDenseResourceElementsAttribute
-  getFromBuffer(py::buffer buffer, std::string name, PyType type,
+  getFromBuffer(py::buffer buffer, const std::string &name, const PyType &type,
                 std::optional<size_t> alignment, bool isMutable,
                 DefaultingPyMlirContext contextWrapper) {
     if (!mlirTypeIsAShaped(type)) {


        


More information about the Mlir-commits mailing list