[Mlir-commits] [mlir] [mlir][linalg] Expose transform.fuse_into_containing_op helpers: NFC (PR #72473)

[Quinn Dawkins]

qedawkins wrote:

> Can you explain the intended use of these internal implementation details ?
> 
> I'd prefer to see this extended to also work properly with scf::ForOp or more generally than make the current implementation load-bearing to downstream clients by exposing the API.

The only helper I really want here is `tileAndFuseFirstExtractUseThroughContainingOpBlockArgument` to fuse through block arguments. I couldn't find an analog anywhere else and the pattern seems quite unique to `scf.forall`. I figured then that exposing just that one would be strange.

Makes sense that wildly exposing internal implementation details would either subject downstream to frequent API breakages, or hinder upstream's ability to make changes. If I had a way to invoke `FuseIntoContainingOp::apply` directly without having to find a place to build the op and set up the full interpreter, that might be preferred. ~~Maybe making this usable outside of testing contexts? https://github.com/llvm/llvm-project/blob/181b2c1b4aae09b9d3bdd0c4f8fda705cccf1b5b/mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h#L67~~

https://github.com/llvm/llvm-project/pull/72473