[Mlir-commits] [mlir] [MLIR] Add 'const' qualifier to some functions (PR #72430)

Markus Böck llvmlistbot at llvm.org
Wed Nov 15 12:30:58 PST 2023


https://github.com/zero9178 requested changes to this pull request.

Does this attempt to solve a specific issue or is this just a nice to have?

Marking these `const` somewhat goes against the "usage of const" rationale:
https://mlir.llvm.org/docs/Rationale/UsageOfConst/
IR constructs, which `mlir::Value` definitely is, simply should never appear as `const` and therefore marking the methods `const` would set the wrong precedence I fear.

https://github.com/llvm/llvm-project/pull/72430


More information about the Mlir-commits mailing list