[Mlir-commits] [mlir] [MLIR] Add support for frame pointers in MLIR (PR #72145)

Tobias Gysi llvmlistbot at llvm.org
Wed Nov 15 08:18:31 PST 2023


================
@@ -1602,7 +1602,9 @@ static void processPassthroughAttrs(llvm::Function *func, LLVMFuncOp funcOp) {
     // explicit attribute.
     // Also skip the vscale_range, it is also an explicit attribute.
     if (attrName == "aarch64_pstate_sm_enabled" ||
-        attrName == "aarch64_pstate_sm_body" || attrName == "vscale_range")
+        attrName == "aarch64_pstate_sm_body" || 
----------------
gysit wrote:

Let's maybe update the comment above to something more generic not enumerating all the attributes (since this will be outdated once we add the next explicit attribute. What about putting something like this:

    // Skip all function attributes that have an explicit attribute in the 
    // LLVMFuncOp argument list and thus should not be stored in the 
    // passthrough attribute dictionary.

https://github.com/llvm/llvm-project/pull/72145


More information about the Mlir-commits mailing list