[Mlir-commits] [mlir] [mlir][gpu] Introduce `gpu.dynamic_shared_memory` Op (PR #71546)

[Guray Ozen]

================
@@ -32,6 +35,18 @@
 namespace mlir {
 namespace gpu {
 
+/// GPU memory space identifiers.
+enum GPUMemorySpace {
+  /// Generic memory space identifier.
+  kGenericMemorySpace = 0,
+
+  /// Global memory space identifier.
+  kGlobalMemorySpace = 1,
+
+  /// Shared memory space identifier.
+  kSharedMemorySpace = 3
+};
----------------
grypp wrote:

Got it. I misunderstood earlier. We can indeed eliminate the `GPUMemorySpace` enum usage and rely solely on the Attribute. 

Actually, the enum isn't used in mlir or IREE, and it doesn't align with the Attribute (e.g., `kSharedMemorySpace = 3` in the enum versus `Workgroup = 2` in the Attribute). I've removed the enum.

https://github.com/llvm/llvm-project/pull/71546