[Mlir-commits] [mlir] [mlir] Add optional layout attribute to VectorType (PR #71916)

Diego Caballero llvmlistbot at llvm.org
Fri Nov 10 10:17:29 PST 2023


dcaballe wrote:

Hey Hash, thanks for the proposal. This is an interesting change! Some initial questions that come to mind:
* How would we lower something like this to LLVM?
* Should this be a property of the type or of the operations supporting these swizzles? In the doc you mention that this is mostly for SIMT matmuls, which make me wonder if we should only make this available for those ops.
* Assuming this should be a property of the type, should we consider a "LayoutVectorType", where the attribute is not optional but mandatory?
* It would be very helpful to add a bunch for IR examples. I would help me get a clearer idea of what we are trying to achieve here.

This looks like a big change so I would give it enough time to settle. Perhaps we should discuss some of these questions around an RFC?

https://github.com/llvm/llvm-project/pull/71916


More information about the Mlir-commits mailing list