[Mlir-commits] [mlir] [mlir][linalg][NFC] Remove linalg subset hoisting (PR #70636)

[Matthias Springer]

matthias-springer wrote:

Sorry to hear that this has caused headaches during integration.

I break down my changes into multiple as small as possible commits to make the reviews easier. And then merge the PRs all at once. The last two changes of the subset hoisting have landed on a different day this time. So while it looks like lots of things have changed, most of the changes were related to subset hoisting.

I usually describe how to migrate code (like in the [`get_parent_for` change](https://github.com/llvm/llvm-project/pull/70757) commit message) for non-trivial changes, but forgot to mention in the commit message of the `SubsetOpInterface` change how to [conservatively implement](https://github.com/llvm/llvm-project/pull/70617/files#diff-e7c08a0e67738b811000e3ff6fcd51d06ac9a5fa0b60a0bcacf2d7618853fe03R18) the new `SubsetOpInterface` for existing `SubsetInsertionOpInterface` ops. I think that was the crucial piece of missing information that made the sequence of commits difficult to integrate.


https://github.com/llvm/llvm-project/pull/70636