[Mlir-commits] [mlir] [llvm] Shard the public llvm-config.h in multiple files (NFC) (PR #71273)

Matt Arsenault llvmlistbot at llvm.org
Mon Nov 6 22:53:58 PST 2023


https://github.com/arsenm commented:

I think using cmakedefine01 is an improvement. As far as splitting every option into its own header, I've never wanted to dynamically flip between these. These mostly look like the kind of options I'd be surprised would even work to change after setting once in the CMakeCache. 

Isn't there an additional cost to reading N smaller files?

https://github.com/llvm/llvm-project/pull/71273


More information about the Mlir-commits mailing list