[Mlir-commits] [mlir] [mlir][python] value casting (PR #69644)

[Oleksandr Alex Zinenko]

================
@@ -35,14 +36,57 @@ def testFastMathFlags():
             print(r)
 
 
-# CHECK-LABEL: TEST: testArithValueBuilder
+# CHECK-LABEL: TEST: testArithValue
 @run
-def testArithValueBuilder():
+def testArithValue():
+    def _binary_op(lhs, rhs, op: str) -> "ArithValue":
+        op = op.capitalize()
+        if arith._is_float_type(lhs.type):
----------------
ftynse wrote:

Should we also check the RHS? Otherwise we may allow arithmetic between floats and integers, which likely isn't something we want.

https://github.com/llvm/llvm-project/pull/69644