[Mlir-commits] [mlir] [MLIR][MemRefToLLVM] Remove last typed pointer remnants (PR #71113)

Christian Ulmann llvmlistbot at llvm.org
Fri Nov 3 02:26:59 PDT 2023


================
@@ -50,16 +50,16 @@ LLVM::LLVMFuncOp lookupOrCreatePrintCloseFn(ModuleOp moduleOp);
 LLVM::LLVMFuncOp lookupOrCreatePrintCommaFn(ModuleOp moduleOp);
 LLVM::LLVMFuncOp lookupOrCreatePrintNewlineFn(ModuleOp moduleOp);
 LLVM::LLVMFuncOp lookupOrCreateMallocFn(ModuleOp moduleOp, Type indexType,
-                                        bool opaquePointers);
+                                        bool opaquePointers = true);
----------------
Dinistro wrote:

I have a followup that removes all of these in one go, but I cannot stack PRs that use branches of my fork. The functions in `FunctionCallUtils.h` are also used in the LLVM utils helpers from `LLVMCommon`.

Once this and the https://github.com/llvm/llvm-project/pull/71075 have been landed, I'll open the other PR that removes all of this.

https://github.com/llvm/llvm-project/pull/71113


More information about the Mlir-commits mailing list