[Mlir-commits] [mlir] eddcf48 - Adopt Properties to store operations inherent Attributes in the Transform dialect

[Mehdi Amini]

Author: Mehdi Amini
Date: 2023-05-15T15:36:16-07:00
New Revision: eddcf480f51548c923e400d1d5e80fcde60bfc6f

URL: https://github.com/llvm/llvm-project/commit/eddcf480f51548c923e400d1d5e80fcde60bfc6f
DIFF: https://github.com/llvm/llvm-project/commit/eddcf480f51548c923e400d1d5e80fcde60bfc6f.diff

LOG: Adopt Properties to store operations inherent Attributes in the Transform dialect

This is part of an on-going migration to adopt Properties inside MLIR.

Differential Revision: https://reviews.llvm.org/D148938

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td
    mlir/test/Dialect/Transform/ops-invalid.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td b/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td
index f034f3a277f52..160f1ff6ec627 100644
--- a/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td
+++ b/mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td
@@ -24,6 +24,7 @@ def Transform_Dialect : Dialect {
   ];
 
   let hasOperationAttrVerify = 1;
+  let usePropertiesForAttributes = 1;
 
   let extraClassDeclaration = [{
       /// Name of the attribute attachable to the symbol table operation

diff  --git a/mlir/test/Dialect/Transform/ops-invalid.mlir b/mlir/test/Dialect/Transform/ops-invalid.mlir
index ec98c6def5637..988743e93ef5c 100644
--- a/mlir/test/Dialect/Transform/ops-invalid.mlir
+++ b/mlir/test/Dialect/Transform/ops-invalid.mlir
@@ -350,7 +350,7 @@ module attributes { transform.with_named_sequence } {
   transform.sequence failures(suppress) {
   ^bb0(%arg0: !transform.any_op):
     // expected-error @below {{requires attribute 'target'}}
-    "transform.include"() {failure_propagation_mode = 0} : () -> ()
+    "transform.include"() {failure_propagation_mode = 1 : i32} : () -> ()
   }
 }