[Mlir-commits] [mlir] 4eb1f1f - [mlir] Apply ClangTidyLegacy findings (NFC)

Adrian Kuegel llvmlistbot at llvm.org
Wed Mar 8 01:40:39 PST 2023


Author: Adrian Kuegel
Date: 2023-03-08T10:39:21+01:00
New Revision: 4eb1f1fab35d0f386b458bf1da4396bbeb00b04f

URL: https://github.com/llvm/llvm-project/commit/4eb1f1fab35d0f386b458bf1da4396bbeb00b04f
DIFF: https://github.com/llvm/llvm-project/commit/4eb1f1fab35d0f386b458bf1da4396bbeb00b04f.diff

LOG: [mlir] Apply ClangTidyLegacy findings (NFC)

- 'override' is redundant since the function is already declared 'final'.
- 'virtual' is redundant since the function is already declared 'override'.

Added: 
    

Modified: 
    mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp b/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
index f705284845a2d..c56d03f6f31d7 100644
--- a/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
+++ b/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
@@ -819,7 +819,7 @@ class VectorMaskOpConversionBase
 
   LogicalResult
   matchAndRewrite(vector::MaskOp maskOp, OpAdaptor adaptor,
-                  ConversionPatternRewriter &rewriter) const override final {
+                  ConversionPatternRewriter &rewriter) const final {
     // Match against the maskable operation kind.
     auto maskedOp = llvm::dyn_cast_or_null<MaskedOp>(maskOp.getMaskableOp());
     if (!maskedOp)
@@ -841,7 +841,7 @@ class MaskedReductionOpConversion
   using VectorMaskOpConversionBase<
       vector::ReductionOp>::VectorMaskOpConversionBase;
 
-  virtual LogicalResult matchAndRewriteMaskableOp(
+  LogicalResult matchAndRewriteMaskableOp(
       vector::MaskOp maskOp, MaskableOpInterface maskableOp,
       ConversionPatternRewriter &rewriter) const override {
     auto reductionOp = cast<ReductionOp>(maskableOp.getOperation());


        


More information about the Mlir-commits mailing list