[Mlir-commits] [mlir] 8abbc96 - [mlir][vector][transform] Drop redundant "apply_" from op names

[Matthias Springer]

Author: Matthias Springer
Date: 2023-06-08T09:00:12+02:00
New Revision: 8abbc96885c836de6912a5f4327519c09f4e528a

URL: https://github.com/llvm/llvm-project/commit/8abbc96885c836de6912a5f4327519c09f4e528a
DIFF: https://github.com/llvm/llvm-project/commit/8abbc96885c836de6912a5f4327519c09f4e528a.diff

LOG: [mlir][vector][transform] Drop redundant "apply_" from op names

This is for consistency with the other ops.

Differential Revision: https://reviews.llvm.org/D152355

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Vector/TransformOps/VectorTransformOps.td
    mlir/test/Dialect/LLVM/transform-e2e.mlir
    mlir/test/Dialect/Vector/transform-vector.mlir
    mlir/test/Dialect/Vector/vector-transfer-drop-unit-dims-patterns.mlir
    mlir/test/Dialect/Vector/vector-transfer-to-vector-load-store.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Vector/TransformOps/VectorTransformOps.td b/mlir/include/mlir/Dialect/Vector/TransformOps/VectorTransformOps.td
index d9d69c53be0f5..253aeedf15aba 100644
--- a/mlir/include/mlir/Dialect/Vector/TransformOps/VectorTransformOps.td
+++ b/mlir/include/mlir/Dialect/Vector/TransformOps/VectorTransformOps.td
@@ -31,7 +31,7 @@ def ApplyCastAwayVectorLeadingOneDimPatternsOp : Op<Transform_Dialect,
 }
 
 def ApplyRankReducingSubviewPatternsOp : Op<Transform_Dialect,
-    "apply_patterns.vector.apply_rank_reducing_subview_patterns",
+    "apply_patterns.vector.rank_reducing_subview_patterns",
     [DeclareOpInterfaceMethods<PatternDescriptorOpInterface>]> {
   let description = [{
     Apply opt-in vector transfer permutation patterns that include:
@@ -47,7 +47,7 @@ def ApplyRankReducingSubviewPatternsOp : Op<Transform_Dialect,
 }
 
 def ApplyTransferPermutationPatternsOp : Op<Transform_Dialect,
-    "apply_patterns.vector.apply_transfer_permutation_patterns",
+    "apply_patterns.vector.transfer_permutation_patterns",
     [DeclareOpInterfaceMethods<PatternDescriptorOpInterface>]> {
   let description = [{
     Apply opt-in vector transfer permutation patterns that include:

diff  --git a/mlir/test/Dialect/LLVM/transform-e2e.mlir b/mlir/test/Dialect/LLVM/transform-e2e.mlir
index 049e893b53fa5..25cf749f495ed 100644
--- a/mlir/test/Dialect/LLVM/transform-e2e.mlir
+++ b/mlir/test/Dialect/LLVM/transform-e2e.mlir
@@ -32,7 +32,7 @@ transform.sequence failures(propagate) {
   } : !transform.any_op
 
   transform.apply_patterns to %f {
-    transform.apply_patterns.vector.apply_transfer_permutation_patterns
+    transform.apply_patterns.vector.transfer_permutation_patterns
   } : !transform.any_op
 
   transform.apply_patterns to %f {

diff  --git a/mlir/test/Dialect/Vector/transform-vector.mlir b/mlir/test/Dialect/Vector/transform-vector.mlir
index 15f423f854d93..ee2c80a33834c 100644
--- a/mlir/test/Dialect/Vector/transform-vector.mlir
+++ b/mlir/test/Dialect/Vector/transform-vector.mlir
@@ -35,7 +35,7 @@ transform.sequence failures(propagate) {
   } : !transform.any_op
 
   transform.apply_patterns to %f {
-    transform.apply_patterns.vector.apply_transfer_permutation_patterns
+    transform.apply_patterns.vector.transfer_permutation_patterns
   } : !transform.any_op
 
   transform.apply_patterns to %f {

diff  --git a/mlir/test/Dialect/Vector/vector-transfer-drop-unit-dims-patterns.mlir b/mlir/test/Dialect/Vector/vector-transfer-drop-unit-dims-patterns.mlir
index d64f8889d6820..77bbcb9bbbb84 100644
--- a/mlir/test/Dialect/Vector/vector-transfer-drop-unit-dims-patterns.mlir
+++ b/mlir/test/Dialect/Vector/vector-transfer-drop-unit-dims-patterns.mlir
@@ -18,7 +18,7 @@ func.func @transfer_read_rank_reducing(
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
@@ -40,7 +40,7 @@ func.func @transfer_write_rank_reducing(%arg : memref<1x1x3x2xi8, strided<[6, 6,
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
@@ -64,7 +64,7 @@ func.func @transfer_read_and_vector_rank_reducing(
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
@@ -88,7 +88,7 @@ func.func @transfer_write_and_vector_rank_reducing(
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
@@ -112,7 +112,7 @@ func.func @transfer_read_and_vector_rank_reducing_to_0d(
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }
 
@@ -136,6 +136,6 @@ func.func @transfer_write_and_vector_rank_reducing_to_0d(
 transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
-    transform.apply_patterns.vector.apply_rank_reducing_subview_patterns
+    transform.apply_patterns.vector.rank_reducing_subview_patterns
   } : !transform.any_op
 }

diff  --git a/mlir/test/Dialect/Vector/vector-transfer-to-vector-load-store.mlir b/mlir/test/Dialect/Vector/vector-transfer-to-vector-load-store.mlir
index ad9bec92173b1..992f5127c8d69 100644
--- a/mlir/test/Dialect/Vector/vector-transfer-to-vector-load-store.mlir
+++ b/mlir/test/Dialect/Vector/vector-transfer-to-vector-load-store.mlir
@@ -242,7 +242,7 @@ transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
     transform.apply_patterns.vector.lower_transfer max_transfer_rank = 99
-    transform.apply_patterns.vector.apply_transfer_permutation_patterns
+    transform.apply_patterns.vector.transfer_permutation_patterns
   } : !transform.any_op
 }
 
@@ -364,6 +364,6 @@ transform.sequence failures(propagate) {
 ^bb1(%module_op: !transform.any_op):
   transform.apply_patterns to %module_op {
     transform.apply_patterns.vector.lower_transfer max_transfer_rank = 99
-    transform.apply_patterns.vector.apply_transfer_permutation_patterns
+    transform.apply_patterns.vector.transfer_permutation_patterns
   } : !transform.any_op
 }