[Mlir-commits] [mlir] 80deb1e - [mlir][ods] Custom builder with no params

[Jacques Pienaar]

Author: Jacques Pienaar
Date: 2020-09-23T08:11:13-07:00
New Revision: 80deb1e106a8c3c5ba31ef0bb4d7651acb6e6b69

URL: https://github.com/llvm/llvm-project/commit/80deb1e106a8c3c5ba31ef0bb4d7651acb6e6b69
DIFF: https://github.com/llvm/llvm-project/commit/80deb1e106a8c3c5ba31ef0bb4d7651acb6e6b69.diff

LOG: [mlir][ods] Custom builder with no params

Incorrect generation of custom build method without any params.

Added: 
    

Modified: 
    mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp b/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
index 58a1b33e4acf..f89547d90493 100644
--- a/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
@@ -1191,8 +1191,9 @@ void OpEmitter::genBuilder() {
         std::string paramStr =
             skipParamGen ? params.str()
                          : llvm::formatv("::mlir::OpBuilder &{0}, "
-                                         "::mlir::OperationState &{1}, {2}",
-                                         builder, builderOpState, params)
+                                         "::mlir::OperationState &{1}{2}{3}",
+                                         builder, builderOpState,
+                                         params.empty() ? "" : ", ", params)
                                .str();
         auto *method =
             opClass.addMethodAndPrune("void", "build", properties, paramStr);