[Mlir-commits] [mlir] a2b6c75 - [mlir] Rename BufferPlacement.h to Bufferize.h

[Sean Silva]

Author: Sean Silva
Date: 2020-10-09T17:48:20-07:00
New Revision: a2b6c75ac0035461ad58930fad89c1fa6de271a0

URL: https://github.com/llvm/llvm-project/commit/a2b6c75ac0035461ad58930fad89c1fa6de271a0
DIFF: https://github.com/llvm/llvm-project/commit/a2b6c75ac0035461ad58930fad89c1fa6de271a0.diff

LOG: [mlir] Rename BufferPlacement.h to Bufferize.h

Context: https://llvm.discourse.group/t/what-is-the-strategy-for-tensor-memref-conversion-bufferization/1938/14

Differential Revision: https://reviews.llvm.org/D89174

Added: 
    mlir/include/mlir/Transforms/Bufferize.h

Modified: 
    mlir/lib/Dialect/Linalg/Transforms/TensorsToBuffers.cpp
    mlir/lib/Dialect/Shape/Transforms/ShapeTypeConversion.cpp
    mlir/lib/Transforms/BufferPlacement.cpp
    mlir/test/lib/Transforms/TestBufferPlacement.cpp

Removed: 
    mlir/include/mlir/Transforms/BufferPlacement.h


################################################################################
diff  --git a/mlir/include/mlir/Transforms/BufferPlacement.h b/mlir/include/mlir/Transforms/Bufferize.h
similarity index 95%
rename from mlir/include/mlir/Transforms/BufferPlacement.h
rename to mlir/include/mlir/Transforms/Bufferize.h
index 8d3e476928b7..e8fffcfe4925 100644
--- a/mlir/include/mlir/Transforms/BufferPlacement.h
+++ b/mlir/include/mlir/Transforms/Bufferize.h
@@ -1,4 +1,4 @@
-//===- BufferPlacement.h - Buffer Assignment Utilities ---------*- C++ -*-===//
+//===- Bufferize.h - Bufferization utilities --------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,13 +6,17 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// This header file defines buffer assignment helper methods to compute correct
-// and valid positions for placing Alloc and Dealloc operations.
+// We use the term "bufferize" to mean conversion from tensor types to
+// memref types.
+//
+// Generally speaking, for each op that operates on tensor types, a conversion
+// pattern needs to be written. The infrastructure in this file assists in
+// defining these conversion patterns in a composable way.
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef MLIR_TRANSFORMS_BUFFERPLACEMENT_H
-#define MLIR_TRANSFORMS_BUFFERPLACEMENT_H
+#ifndef MLIR_TRANSFORMS_BUFFERIZE_H
+#define MLIR_TRANSFORMS_BUFFERIZE_H
 
 #include "mlir/Analysis/Liveness.h"
 #include "mlir/Dialect/StandardOps/IR/Ops.h"
@@ -256,4 +260,4 @@ static void populateWithBufferAssignmentOpConversionPatterns(
 }
 } // end namespace mlir
 
-#endif // MLIR_TRANSFORMS_BUFFERPLACEMENT_H
+#endif // MLIR_TRANSFORMS_BUFFERIZE_H

diff  --git a/mlir/lib/Dialect/Linalg/Transforms/TensorsToBuffers.cpp b/mlir/lib/Dialect/Linalg/Transforms/TensorsToBuffers.cpp
index a9ec621efb9a..bb37a2ec10df 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/TensorsToBuffers.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/TensorsToBuffers.cpp
@@ -20,7 +20,7 @@
 #include "mlir/IR/Function.h"
 #include "mlir/IR/Operation.h"
 #include "mlir/Pass/Pass.h"
-#include "mlir/Transforms/BufferPlacement.h"
+#include "mlir/Transforms/Bufferize.h"
 
 namespace {
 

diff  --git a/mlir/lib/Dialect/Shape/Transforms/ShapeTypeConversion.cpp b/mlir/lib/Dialect/Shape/Transforms/ShapeTypeConversion.cpp
index 6f4c96b87ca7..e281cea24e73 100644
--- a/mlir/lib/Dialect/Shape/Transforms/ShapeTypeConversion.cpp
+++ b/mlir/lib/Dialect/Shape/Transforms/ShapeTypeConversion.cpp
@@ -18,7 +18,7 @@
 #include "mlir/IR/Operation.h"
 #include "mlir/IR/StandardTypes.h"
 #include "mlir/Pass/Pass.h"
-#include "mlir/Transforms/BufferPlacement.h"
+#include "mlir/Transforms/Bufferize.h"
 
 using namespace mlir;
 using namespace mlir::shape;

diff  --git a/mlir/lib/Transforms/BufferPlacement.cpp b/mlir/lib/Transforms/BufferPlacement.cpp
index 4f97fb836246..380c72087bbd 100644
--- a/mlir/lib/Transforms/BufferPlacement.cpp
+++ b/mlir/lib/Transforms/BufferPlacement.cpp
@@ -55,11 +55,11 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "mlir/Transforms/BufferPlacement.h"
 #include "PassDetail.h"
 #include "mlir/Dialect/Linalg/IR/LinalgOps.h"
 #include "mlir/IR/Operation.h"
 #include "mlir/Pass/Pass.h"
+#include "mlir/Transforms/Bufferize.h"
 #include "mlir/Transforms/Passes.h"
 #include "llvm/ADT/SetOperations.h"
 

diff  --git a/mlir/test/lib/Transforms/TestBufferPlacement.cpp b/mlir/test/lib/Transforms/TestBufferPlacement.cpp
index 3b31ac0d1a70..aecf99f69729 100644
--- a/mlir/test/lib/Transforms/TestBufferPlacement.cpp
+++ b/mlir/test/lib/Transforms/TestBufferPlacement.cpp
@@ -18,7 +18,7 @@
 #include "mlir/IR/Operation.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Pass/PassManager.h"
-#include "mlir/Transforms/BufferPlacement.h"
+#include "mlir/Transforms/Bufferize.h"
 
 using namespace mlir;