[Mlir-commits] [mlir] d3530e9 - [MLIR][cmake] don't glob for sources.

[Stephen Neuendorffer]

Author: Stephen Neuendorffer
Date: 2020-05-13T23:21:01-07:00
New Revision: d3530e95f1d4c97cf24e77c6db2d32ee5344d4ee

URL: https://github.com/llvm/llvm-project/commit/d3530e95f1d4c97cf24e77c6db2d32ee5344d4ee
DIFF: https://github.com/llvm/llvm-project/commit/d3530e95f1d4c97cf24e77c6db2d32ee5344d4ee.diff

LOG: [MLIR][cmake] don't glob for sources.

Generally speaking, this is bad practice.  It also causes the build to
break if there are editor temporary files.

Differential Revision: https://reviews.llvm.org/D79906

Added: 
    

Modified: 
    mlir/lib/Dialect/SCF/CMakeLists.txt
    mlir/lib/IR/CMakeLists.txt
    mlir/lib/Pass/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/SCF/CMakeLists.txt b/mlir/lib/Dialect/SCF/CMakeLists.txt
index 9565a85b3f7b..5bdb621c1a48 100644
--- a/mlir/lib/Dialect/SCF/CMakeLists.txt
+++ b/mlir/lib/Dialect/SCF/CMakeLists.txt
@@ -1,6 +1,5 @@
-file(GLOB globbed *.c *.cpp)
 add_mlir_dialect_library(MLIRSCF
-  ${globbed}
+  SCF.cpp
   EDSC/Builders.cpp
 
   ADDITIONAL_HEADER_DIRS

diff  --git a/mlir/lib/IR/CMakeLists.txt b/mlir/lib/IR/CMakeLists.txt
index 2d5f5cb9e2b4..8bf61c0a3ec3 100644
--- a/mlir/lib/IR/CMakeLists.txt
+++ b/mlir/lib/IR/CMakeLists.txt
@@ -1,6 +1,30 @@
-file(GLOB globbed *.c *.cpp)
 add_mlir_library(MLIRIR
-  ${globbed}
+  AffineExpr.cpp
+  AffineMap.cpp
+  AsmPrinter.cpp
+  Attributes.cpp
+  Block.cpp
+  Builders.cpp
+  Diagnostics.cpp
+  Dialect.cpp
+  Dominance.cpp
+  Function.cpp
+  FunctionImplementation.cpp
+  IntegerSet.cpp
+  Location.cpp
+  MLIRContext.cpp
+  Module.cpp
+  Operation.cpp
+  OperationSupport.cpp
+  PatternMatch.cpp
+  Region.cpp
+  StandardTypes.cpp
+  SymbolTable.cpp
+  Types.cpp
+  TypeUtilities.cpp
+  Value.cpp
+  Verifier.cpp
+  Visitors.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/IR

diff  --git a/mlir/lib/Pass/CMakeLists.txt b/mlir/lib/Pass/CMakeLists.txt
index c012b056dba3..3ec596e7a7c2 100644
--- a/mlir/lib/Pass/CMakeLists.txt
+++ b/mlir/lib/Pass/CMakeLists.txt
@@ -1,6 +1,10 @@
-file(GLOB globbed *.c *.cpp)
 add_mlir_library(MLIRPass
-  ${globbed}
+  IRPrinting.cpp
+  Pass.cpp
+  PassManagerOptions.cpp
+  PassRegistry.cpp
+  PassStatistics.cpp
+  PassTiming.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Pass