[Mlir-commits] [mlir] 42d8f48 - Fix a warning building on my machine, NFC. warning: unused function 'compilePtxToCubinForTesting'

Chris Lattner llvmlistbot at llvm.org
Mon Mar 23 11:17:02 PDT 2020


Author: Chris Lattner
Date: 2020-03-23T11:16:55-07:00
New Revision: 42d8f48ccfcd48a1dba76a14a86d45eec27ca649

URL: https://github.com/llvm/llvm-project/commit/42d8f48ccfcd48a1dba76a14a86d45eec27ca649
DIFF: https://github.com/llvm/llvm-project/commit/42d8f48ccfcd48a1dba76a14a86d45eec27ca649.diff

LOG: Fix a warning building on my machine, NFC. warning: unused function 'compilePtxToCubinForTesting'

Summary: Also eliminate the redunant anon namespace around the already static function.

Reviewers: herhut

Subscribers: hiraditya, steven_wu, dexonsmith, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, csigg, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D76627

Added: 
    

Modified: 
    mlir/test/lib/Transforms/TestConvertGPUKernelToCubin.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/test/lib/Transforms/TestConvertGPUKernelToCubin.cpp b/mlir/test/lib/Transforms/TestConvertGPUKernelToCubin.cpp
index 2a2259547b37..e0c4c1907c4f 100644
--- a/mlir/test/lib/Transforms/TestConvertGPUKernelToCubin.cpp
+++ b/mlir/test/lib/Transforms/TestConvertGPUKernelToCubin.cpp
@@ -9,18 +9,15 @@
 #include "mlir/Conversion/GPUToCUDA/GPUToCUDAPass.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Pass/PassManager.h"
-
 using namespace mlir;
 
-namespace {
+#if MLIR_CUDA_CONVERSIONS_ENABLED
 static OwnedCubin compilePtxToCubinForTesting(const std::string &, Location,
                                               StringRef) {
   const char data[] = "CUBIN";
   return std::make_unique<std::vector<char>>(data, data + sizeof(data) - 1);
 }
-} // end anonymous namespace
 
-#if MLIR_CUDA_CONVERSIONS_ENABLED
 namespace mlir {
 void registerTestConvertGPUKernelToCubinPass() {
   PassPipelineRegistration<>("test-kernel-to-cubin",


        


More information about the Mlir-commits mailing list