[Mlir-commits] [mlir] 7d91fd2 - [mlir] NFC: update documentation in ConvertLinalgToLLVM

Alex Zinenko llvmlistbot at llvm.org
Tue Feb 25 06:16:21 PST 2020


Author: Alex Zinenko
Date: 2020-02-25T15:16:14+01:00
New Revision: 7d91fd23dfa8ad33b3d270b6a2b8f6cf6a589a38

URL: https://github.com/llvm/llvm-project/commit/7d91fd23dfa8ad33b3d270b6a2b8f6cf6a589a38
DIFF: https://github.com/llvm/llvm-project/commit/7d91fd23dfa8ad33b3d270b6a2b8f6cf6a589a38.diff

LOG: [mlir] NFC: update documentation in ConvertLinalgToLLVM

The documentation was describing an obsolete version of the
transformation.

Added: 
    

Modified: 
    mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp b/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
index 72806aa4b7fc..1774f93b7254 100644
--- a/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
+++ b/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
@@ -194,12 +194,10 @@ class ReshapeOpConversion : public ConvertToLLVMPattern {
 };
 
 /// Conversion pattern that transforms a linalg.slice op into:
-///   1. A function entry `alloca` operation to allocate a ViewDescriptor.
-///   2. A load of the ViewDescriptor from the pointer allocated in 1.
-///   3. Updates to the ViewDescriptor to introduce the data ptr, offset, size
+///   1. An "undef" value for the ViewDescriptor.
+///   2. Updates to the ViewDescriptor to introduce the data ptr, offset, size
 ///      and stride corresponding to the region of memory within the bounds of
 ///      the parent view.
-///   4. A store of the resulting ViewDescriptor to the alloca'ed pointer.
 /// The linalg.slice op is replaced by the alloca'ed pointer.
 class SliceOpConversion : public ConvertToLLVMPattern {
 public:


        


More information about the Mlir-commits mailing list