[Mlir-commits] [mlir] 9412e4c - [MLIR] NFC Fix/clarify line in const usage rationale doc

Uday Bondhugula llvmlistbot at llvm.org
Sat Apr 18 23:27:47 PDT 2020


Author: Uday Bondhugula
Date: 2020-04-19T11:55:53+05:30
New Revision: 9412e4c9c67a15e44d67a99b9ea8d98e36530a7e

URL: https://github.com/llvm/llvm-project/commit/9412e4c9c67a15e44d67a99b9ea8d98e36530a7e
DIFF: https://github.com/llvm/llvm-project/commit/9412e4c9c67a15e44d67a99b9ea8d98e36530a7e.diff

LOG: [MLIR] NFC Fix/clarify line in const usage rationale doc

Update misleading line in conclusions. Although the application to IR
objects is stated earlier, the concluding section contradicts it in
isolation.

Differential Revision: https://reviews.llvm.org/D78446

Added: 
    

Modified: 
    mlir/docs/Rationale/UsageOfConst.md

Removed: 
    


################################################################################
diff  --git a/mlir/docs/Rationale/UsageOfConst.md b/mlir/docs/Rationale/UsageOfConst.md
index 6e8ce78e960c..1f0d9c6fee2f 100644
--- a/mlir/docs/Rationale/UsageOfConst.md
+++ b/mlir/docs/Rationale/UsageOfConst.md
@@ -257,8 +257,8 @@ As we can see above, there is very little benefit to our const design and
 significant cost, and given that the primary purpose of an IR is to represent
 transformations of code, const is providing very little benefit.
 
-As such, we propose eliminating support for const references in MLIR. This
-implies the following changes to the codebase:
+As such, we propose eliminating support for const references to IR objects in
+MLIR.  This implies the following changes to the codebase:
 
 1.  All of the const-duplicated accessors would be eliminated, e.g.
     `Operation::getParent() const` would be removed. This is expected to remove


        


More information about the Mlir-commits mailing list