[Mlir-commits] [mlir] 0f37454 - Fix typos in toy tutorial

Mehdi Amini llvmlistbot at llvm.org
Fri Apr 3 20:17:44 PDT 2020


Author: Frederik Gossen
Date: 2020-04-04T03:17:24Z
New Revision: 0f37454c7238cfe95c5d6b427b2c400c084944aa

URL: https://github.com/llvm/llvm-project/commit/0f37454c7238cfe95c5d6b427b2c400c084944aa
DIFF: https://github.com/llvm/llvm-project/commit/0f37454c7238cfe95c5d6b427b2c400c084944aa.diff

LOG: Fix typos in toy tutorial

 Fix two typos throughout the chapters.

Differential Revision: https://reviews.llvm.org/D77397

Added: 
    

Modified: 
    mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
    mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
    mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
    mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
    mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
    mlir/examples/toy/Ch7/mlir/MLIRGen.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/examples/toy/Ch2/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
index 5e09e73b27be..ef9862505e8c 100644
--- a/mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
@@ -313,7 +313,7 @@ class MLIRGenImpl {
       operands.push_back(arg);
     }
 
-    // Builting calls have their custom operation, meaning this is a
+    // Builtin calls have their custom operation, meaning this is a
     // straightforward emission.
     if (callee == "transpose") {
       if (call.getArgs().size() != 1) {
@@ -324,9 +324,9 @@ class MLIRGenImpl {
       return builder.create<TransposeOp>(location, operands[0]);
     }
 
-    // Otherwise this is a call to a user-defined function. Calls to ser-defined
-    // functions are mapped to a custom call that takes the callee name as an
-    // attribute.
+    // Otherwise this is a call to a user-defined function. Calls to
+    // user-defined functions are mapped to a custom call that takes the callee
+    // name as an attribute.
     return builder.create<GenericCallOp>(location, callee, operands);
   }
 

diff  --git a/mlir/examples/toy/Ch3/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
index 5e09e73b27be..ef9862505e8c 100644
--- a/mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
@@ -313,7 +313,7 @@ class MLIRGenImpl {
       operands.push_back(arg);
     }
 
-    // Builting calls have their custom operation, meaning this is a
+    // Builtin calls have their custom operation, meaning this is a
     // straightforward emission.
     if (callee == "transpose") {
       if (call.getArgs().size() != 1) {
@@ -324,9 +324,9 @@ class MLIRGenImpl {
       return builder.create<TransposeOp>(location, operands[0]);
     }
 
-    // Otherwise this is a call to a user-defined function. Calls to ser-defined
-    // functions are mapped to a custom call that takes the callee name as an
-    // attribute.
+    // Otherwise this is a call to a user-defined function. Calls to
+    // user-defined functions are mapped to a custom call that takes the callee
+    // name as an attribute.
     return builder.create<GenericCallOp>(location, callee, operands);
   }
 

diff  --git a/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
index 2be287c8704a..9d770d478c68 100644
--- a/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
@@ -317,7 +317,7 @@ class MLIRGenImpl {
       operands.push_back(arg);
     }
 
-    // Builting calls have their custom operation, meaning this is a
+    // Builtin calls have their custom operation, meaning this is a
     // straightforward emission.
     if (callee == "transpose") {
       if (call.getArgs().size() != 1) {
@@ -328,9 +328,9 @@ class MLIRGenImpl {
       return builder.create<TransposeOp>(location, operands[0]);
     }
 
-    // Otherwise this is a call to a user-defined function. Calls to ser-defined
-    // functions are mapped to a custom call that takes the callee name as an
-    // attribute.
+    // Otherwise this is a call to a user-defined function. Calls to
+    // user-defined functions are mapped to a custom call that takes the callee
+    // name as an attribute.
     return builder.create<GenericCallOp>(location, callee, operands);
   }
 

diff  --git a/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
index 2be287c8704a..9d770d478c68 100644
--- a/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
@@ -317,7 +317,7 @@ class MLIRGenImpl {
       operands.push_back(arg);
     }
 
-    // Builting calls have their custom operation, meaning this is a
+    // Builtin calls have their custom operation, meaning this is a
     // straightforward emission.
     if (callee == "transpose") {
       if (call.getArgs().size() != 1) {
@@ -328,9 +328,9 @@ class MLIRGenImpl {
       return builder.create<TransposeOp>(location, operands[0]);
     }
 
-    // Otherwise this is a call to a user-defined function. Calls to ser-defined
-    // functions are mapped to a custom call that takes the callee name as an
-    // attribute.
+    // Otherwise this is a call to a user-defined function. Calls to
+    // user-defined functions are mapped to a custom call that takes the callee
+    // name as an attribute.
     return builder.create<GenericCallOp>(location, callee, operands);
   }
 

diff  --git a/mlir/examples/toy/Ch6/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
index 2be287c8704a..9d770d478c68 100644
--- a/mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
@@ -317,7 +317,7 @@ class MLIRGenImpl {
       operands.push_back(arg);
     }
 
-    // Builting calls have their custom operation, meaning this is a
+    // Builtin calls have their custom operation, meaning this is a
     // straightforward emission.
     if (callee == "transpose") {
       if (call.getArgs().size() != 1) {
@@ -328,9 +328,9 @@ class MLIRGenImpl {
       return builder.create<TransposeOp>(location, operands[0]);
     }
 
-    // Otherwise this is a call to a user-defined function. Calls to ser-defined
-    // functions are mapped to a custom call that takes the callee name as an
-    // attribute.
+    // Otherwise this is a call to a user-defined function. Calls to
+    // user-defined functions are mapped to a custom call that takes the callee
+    // name as an attribute.
     return builder.create<GenericCallOp>(location, callee, operands);
   }
 

diff  --git a/mlir/examples/toy/Ch7/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
index eeab86de82d4..2794768bee7b 100644
--- a/mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
@@ -501,7 +501,7 @@ class MLIRGenImpl {
       operands.push_back(arg);
     }
 
-    // Builting calls have their custom operation, meaning this is a
+    // Builtin calls have their custom operation, meaning this is a
     // straightforward emission.
     if (callee == "transpose") {
       if (call.getArgs().size() != 1) {
@@ -512,9 +512,9 @@ class MLIRGenImpl {
       return builder.create<TransposeOp>(location, operands[0]);
     }
 
-    // Otherwise this is a call to a user-defined function. Calls to ser-defined
-    // functions are mapped to a custom call that takes the callee name as an
-    // attribute.
+    // Otherwise this is a call to a user-defined function. Calls to
+    // user-defined functions are mapped to a custom call that takes the callee
+    // name as an attribute.
     auto calledFuncIt = functionMap.find(callee);
     if (calledFuncIt == functionMap.end()) {
       emitError(location) << "no defined function found for '" << callee << "'";


        


More information about the Mlir-commits mailing list