<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Yes, you fixed an unreachable abort. Now we're hitting elf-dump test failures on most 32-bit intel builds:<div><br></div><div><div>basic-elf.ll</div><div>diff.s</div><div>local-reloc.s</div><div>got.s</div><div>merge.s</div><div>pic-diff.s</div><div>plt.s</div><div>relax.s</div><div>relocation.s</div></div><div><br></div><div>Failures look like this:</div><div><span class="Apple-style-span" style="font-family: Times; "><pre><span class="stdout" style="font-family: 'Courier New', courier, monotype; ">******************** TEST 'LLVM :: MC/ELF/diff.s' FAILED ********************Script:
--
llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu /home/buildslave-osuosl/llvm/clang-i686-linux/llvm/test/MC/ELF/diff.s -o - | elf-dump | FileCheck /home/buildslave-osuosl/llvm/clang-i686-linux/llvm/test/MC/ELF/diff.s
--
Exit Code: 1
Command Output (stderr):
--
/home/buildslave-osuosl/llvm/clang-i686-linux/llvm/test/MC/ELF/diff.s:13:16: error: expected string not found in input
// CHECK-NEXT: ('r_sym', 0x6)
^
<stdin>:183:2: note: scanning from here
('r_sym', 0x6L)
^
--
********************</span></pre></span><div>Are you familiar enough with the changes to fix it or do a surgical revert? Or shall I commence carpet bombing?</div><div><br></div><div>-Andy</div><div><br></div><div><div><div>On Oct 18, 2010, at 4:21 PM, Rafael Espíndola wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>2010/10/18 Andy Trick <<a href="mailto:atrick@apple.com">atrick@apple.com</a>>:<br><blockquote type="cite">I'd like to believe that. But some of the failing tests built around 3:20pm buildbot time zone. I didn't see any checkins fro you or Jason after 3pm? What am I missing?<br></blockquote><br>Slow bot? Some of the last failures I was mailed were from bots<br>running valgrind for example. I just checked in my home computer and<br>the tests pass. Also, the line reported in the log has no<br>llvm_unreachable in it in the top of the tree.<br><br><blockquote type="cite">-Andy<br></blockquote><br>Cheers,<br>Rafael<br></div></blockquote></div><br></div></div></body></html>