<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Okay, on that builder for that particular time, here's the only change:<div><br></div><div><span class="Apple-style-span" style="font-family: Verdana, Cursor; font-size: 12px; font-weight: bold; "><p>Changed by: <b>lattner</b><br>Changed at: <b>Sat 13 Mar 2010 17:42:23</b><br>Revision: <a href="http://llvm.org/viewvc/llvm-project/?view=rev&revision=98459" style="color: rgb(68, 68, 68); "><b>98459</b></a> <br>Changed files:</p><ul><li><b>include/llvm/CodeGen/JITCodeEmitter.h</b></li><li><b>include/llvm/CodeGen/MachineCodeEmitter.h</b></li><li><b>include/llvm/CodeGen/MachineModuleInfo.h</b></li><li><b>include/llvm/CodeGen/ObjectCodeEmitter.h</b></li><li><b>lib/CodeGen/AsmPrinter/DwarfException.cpp</b></li><li><b>lib/CodeGen/AsmPrinter/DwarfException.h</b></li><li><b>lib/CodeGen/ELFCodeEmitter.h</b></li><li><b>lib/CodeGen/MachineModuleInfo.cpp</b></li><li><b>lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp</b></li><li><b>lib/ExecutionEngine/JIT/JITDwarfEmitter.cpp</b></li><li><b>lib/ExecutionEngine/JIT/JITEmitter.cpp</b></li><li><b>lib/Target/ARM/ARMCodeEmitter.cpp</b></li><li><b>lib/Target/PowerPC/PPCCodeEmitter.cpp</b></li><li><b>lib/Target/X86/X86CodeEmitter.cpp</b></li></ul>Comments:<pre>change EH related stuff (other than EH_LABEL) to use MCSymbol</pre><pre>instead of label ID's. This cleans up and regularizes a bunch
of code and makes way for future progress.
Unfortunately, this pointed out to me that JITDwarfEmitter.cpp
is largely copy and paste from DwarfException/MachineModuleInfo
and other places. This is very sad and disturbing. :(
One major change here is that TidyLandingPads moved from being
called in DwarfException::BeginFunction to being called in
DwarfException::EndFunction. There should not be any
functionality change from doing this, but I'm not an EH expert.
</pre><div><br></div><div><br></div><div><a href="http://smooshlab.apple.com:8010/builders/nnt/builds/1359">http://smooshlab.apple.com:8010/builders/nnt/builds/1359</a></div><div><br></div><div>-bw</div><div><br></div></span><div><div>On Mar 16, 2010, at 11:22 AM, Bill Wendling wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>I didn't see these at all, and I checked several times for regressions after my patch went in. Weird how they slipped by.<br><br>-bw<br><br>On Mar 16, 2010, at 10:00 AM, Evan Cheng wrote:<br><br><blockquote type="cite">These EH failures have been fixed, right?<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Evan<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">On Mar 13, 2010, at 7:21 PM, <a href="mailto:daniel_dunbar@apple.com">daniel_dunbar@apple.com</a> wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite"><a href="http://smooshlab.apple.com/perf/db_nt_internal/nightlytest/6250/">http://smooshlab.apple.com/perf/db_nt_internal/nightlytest/6250/</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Name: smoosh-01<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Nickname: smoosh-01:1<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Run: 6250, Start Time: 2010-03-13 17:53:20, End Time: 2010-03-13 19:21:39<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Comparing To: 6249, Start Time: 2010-03-13 15:22:27, End Time: 2010-03-13 16:51:09<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">--- Changes Summary ---<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">New Test Passes: 0<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">New Test Failures: 20<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Added Tests: 0<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Removed Tests: 0<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Significant Changes: 3<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">--- Tests Summary ---<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Total Tests: 3582<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Total Test Failures: 644<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Total Test Failures By Type:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Bitcode: 66<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">CBE: 84<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">GCCAS: 66<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">JIT: 72<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">JIT codegen: 72<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">LLC: 71<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">LLC compile: 71<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">LLC-BETA: 71<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">LLC_BETA compile: 71<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">--- Changes Detail ---<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">New Test Passes:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">New Test Failures:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">SingleSource/Regression/C++/EH/ctor_dtor_count [LLC, LLC-BETA, LLC compile, LLC_BETA compile]<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">SingleSource/Regression/C++/EH/ctor_dtor_count-2 [LLC, LLC-BETA, LLC compile, LLC_BETA compile]<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">SingleSource/Regression/C++/EH/function_try_block [LLC, LLC-BETA, LLC compile, LLC_BETA compile]<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">SingleSource/Regression/C++/EH/simple_rethrow [LLC, LLC-BETA, LLC compile, LLC_BETA compile]<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">SingleSource/Regression/C++/EH/simple_throw [LLC, LLC-BETA, LLC compile, LLC_BETA compile]<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Added Tests:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Removed Tests:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Significant Changes in Test Results:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">LLC:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">MultiSource/Applications/lambda-0_1_3/lambda: 6.33% (4.7400 => 5.0400)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">JIT:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">SingleSource/Benchmarks/Shootout/lists: -9.33% (6.9700 => 6.3200)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">LLC-BETA:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">MultiSource/Applications/lambda-0_1_3/lambda: -6.18% (5.0200 => 4.7100)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">_______________________________________________<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">llvm-testresults mailing list<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="mailto:llvm-testresults@cs.uiuc.edu">llvm-testresults@cs.uiuc.edu</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-testresults">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-testresults</a><br></blockquote></blockquote><blockquote type="cite"><br></blockquote><br><br>_______________________________________________<br>llvm-testresults mailing list<br><a href="mailto:llvm-testresults@cs.uiuc.edu">llvm-testresults@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-testresults<br></div></blockquote></div><br></div></body></html>