[llvm-testresults] buildbot failure in lab.llvm.org on phase1 - sanity

[llvmlab-buildmaster at lab.llvm.org]

The Buildbot has detected a new failure on builder phase1 - sanity while building llvm.
Full details are available at:
 http://lab.llvm.org:8013/builders/phase1%20-%20sanity/builds/4473

Buildbot URL: http://lab.llvm.org:8013/

Buildslave for this Build: macpro1

Build Reason: scheduler
Build Source Stamp: 217310
Blamelist: chandlerc

BUILD FAILED: failed

sincerely,
 -The Buildbot


================================================================================

CHANGES:
Files:
 include/llvm/IR/IntrinsicsX86.td
 lib/IR/AutoUpgrade.cpp
 lib/Target/X86/AsmParser/X86AsmParserCommon.h
 lib/Target/X86/AsmParser/X86Operand.h
 lib/Target/X86/X86InstrAVX512.td
 lib/Target/X86/X86InstrFragmentsSIMD.td
 lib/Target/X86/X86InstrInfo.td
 lib/Target/X86/X86InstrSSE.td
 test/CodeGen/X86/avx-intrinsics-x86-upgrade.ll
 test/CodeGen/X86/avx-intrinsics-x86.ll
 test/CodeGen/X86/avx.ll
 test/CodeGen/X86/avx2-intrinsics-x86-upgrade.ll
 test/CodeGen/X86/avx2-intrinsics-x86.ll
 test/CodeGen/X86/sse41-intrinsics-x86-upgrade.ll
 test/CodeGen/X86/sse41-intrinsics-x86.ll
 test/CodeGen/X86/sse41.ll
 test/MC/X86/x86-32-coverage.s
 utils/TableGen/X86RecognizableInstr.cpp
On: http://10.1.1.2/svn/llvm-project
For: llvm
At: Sat 06 Sep 2014 03:11:30
Changed By: chandlerc
Comments: [x86] Fix a pretty horrible bug and inconsistency in the x86 asm
parsing (and latent bug in the instruction definitions).

This is effectively a revert of r136287 which tried to address
a specific and narrow case of immediate operands failing to be accepted
by x86 instructions with a pretty heavy hammer: it introduced a new kind
of operand that behaved differently. All of that is removed with this
commit, but the test cases are both preserved and enhanced.

The core problem that r136287 and this commit are trying to handle is
that gas accepts both of the following instructions:

  insertps $192, %xmm0, %xmm1
  insertps $-64, %xmm0, %xmm1

These will encode to the same byte sequence, with the immediate
occupying an 8-bit entry. The first form was fixed by r136287 but that
broke the prior handling of the second form! =[ Ironically, we would
still emit the second form in some cases and then be unable to
re-assemble the output.

The reason why the first instruction failed to be handled is because
prior to r136287 the operands ere marked 'i32i8imm' which forces them to
be sign-extenable. Clearly, that won't work for 192 in a single byte.
However, making thim zero-extended or "unsigned" doesn't really address
the core issue either because it breaks negative immediates. The correct
fix is to make these operands 'i8imm' reflecting that they can be either
signed or unsigned but must be 8-bit immediates. This patch backs out
r136287 and then changes those places as well as some others to use
'i8imm' rather than one of the extended variants.

Naturally, this broke something else. The custom DAG nodes had to be
updated to have a much more accurate type constraint of an i8 node, and
a bunch of Pat immediates needed to be specified as i8 values.

The fallout didn't end there though. We also then ceased to be able to
match the instruction-specific intrinsics to the instructions so
modified. Digging, this is because they too used i32 rather than i8 in
their signature. So I've also switched those intrinsics to i8 arguments
in line with the instructions.

In order to make the intrinsic adjustments of course, I also had to add
auto upgrading for the intrinsics.

I suspect that the intrinsic argument types may have led everything down
this rabbit hole. Pretty happy with the result.Properties: 




LOGS: