[llvm-testresults] buildbot failure in lab.llvm.org on phase1 - sanity

llvmlab-buildmaster at lab.llvm.org llvmlab-buildmaster at lab.llvm.org
Tue Aug 26 15:39:51 PDT 2014


The Buildbot has detected a new failure on builder phase1 - sanity while building cfe.
Full details are available at:
 http://lab.llvm.org:8013/builders/phase1%20-%20sanity/builds/4012

Buildbot URL: http://lab.llvm.org:8013/

Buildslave for this Build: macpro1

Build Reason: scheduler
Build Source Stamp: 216496
Blamelist: jlerouge,kfischer,rafael,rsmith

BUILD FAILED: failed

sincerely,
 -The Buildbot


================================================================================

CHANGES:
File: lib/Sema/SemaDecl.cpp
On: http://10.1.1.2/svn/llvm-project
For: cfe
At: Tue 26 Aug 2014 15:05:33
Changed By: rsmith
Comments: Clarify comment so this doesn't appear to be a C11-only rule.
Properties: 




Files:
 lib/CodeGen/TargetInfo.cpp
 test/CodeGen/2007-06-18-SextAttrAggregate.c
 test/CodeGen/x86_64-arguments-win32.c
On: http://10.1.1.2/svn/llvm-project
For: cfe
At: Tue 26 Aug 2014 15:05:33
Changed By: jlerouge
Comments: Win64 ABI shouldn't extend integer type arguments.

Summary:
MSVC doesn't extend integer types smaller than 64bit, so to preserve
binary compatibility, clang shouldn't either.

For example, the following C code built with MSVC:

unsigned test(unsigned v);
unsigned foobar(unsigned short);
int main() { return test(0xffffffff) + foobar(28); }

Produces the following:

  0000000000000004: B9 FF FF FF FF     mov         ecx,0FFFFFFFFh
  0000000000000009: E8 00 00 00 00     call        test
  000000000000000E: 89 44 24 20        mov         dword ptr [rsp+20h],eax
  0000000000000012: 66 B9 1C 00        mov         cx,1Ch
  0000000000000016: E8 00 00 00 00     call        foobar

And as you can see, when setting up the call to foobar, only cx is overwritten.

If foobar is compiled with clang, then the zero extension added by clang means
the rest of the register, which contains garbage, could be used.

For example if foobar is:

unsigned foobar(unsigned short v) {
    return v;
}

Compiled with clang -fomit-frame-pointer -O3 gives the following assembly:

foobar:
  0000000000000000: 89 C8              mov         eax,ecx
  0000000000000002: C3                 ret

And that function would return garbage because the 16 most significant bits of
ecx still contain garbage from the first call.

With this change, the code for that function is now:

foobar:
  0000000000000000: 0F B7 C1           movzx       eax,cx
  0000000000000003: C3                 ret

Reviewers: chapuni, rnk

Reviewed By: rnk

Subscribers: majnemer, cfe-commits

Differential Revision: http://reviews.llvm.org/D4380Properties: 




Files:
 include/llvm/Bitcode/ReaderWriter.h
 lib/Bitcode/Reader/BitReader.cpp
 lib/Bitcode/Reader/BitcodeReader.cpp
 lib/IRReader/IRReader.cpp
 lib/Object/IRObjectFile.cpp
 tools/gold/gold-plugin.cpp
 unittests/Bitcode/BitReaderTest.cpp
 unittests/ExecutionEngine/JIT/JITTest.cpp
On: http://10.1.1.2/svn/llvm-project
For: llvm
At: Tue 26 Aug 2014 15:11:30
Changed By: rafael
Comments: Pass a std::unique_ptr<MemoryBuffer>& to getLazyBitcodeModule.

By taking a reference we can do the ownership transfer in one place instead of
expecting every caller to do it.Properties: 




File: lib/CodeGen/CodeGenAction.cpp
On: http://10.1.1.2/svn/llvm-project
For: cfe
At: Tue 26 Aug 2014 15:11:30
Changed By: rafael
Comments: Update for llvm api change.Properties: 




Files:
 lib/CodeGen/CGDeclCXX.cpp
 unittests/CMakeLists.txt
 unittests/CodeGen
 unittests/CodeGen/BufferSourceTest.cpp
 unittests/CodeGen/CMakeLists.txt
 unittests/CodeGen/Makefile
 unittests/Makefile
On: http://10.1.1.2/svn/llvm-project
For: cfe
At: Tue 26 Aug 2014 15:21:30
Changed By: kfischer
Comments: Don't segfault in EmitCXXGlobalInitFunc when main file is a membuf

Summary: When the main file is created from a membuffer, there is no file entry that can be retrieved. This uses "__GLOBAL_I_a" in that case which is what was always used before r208128.

Reviewers: majnemer, thakis

Reviewed By: thakis

Subscribers: yaron.keren, rsmith, cfe-commits

Differential Revision: http://reviews.llvm.org/D5043Properties: 




Files:
 lib/CodeGen/TargetInfo.cpp
 test/CodeGen/2007-06-18-SextAttrAggregate.c
 test/CodeGen/x86_64-arguments-win32.c
On: http://10.1.1.2/svn/llvm-project
For: cfe
At: Tue 26 Aug 2014 15:25:30
Changed By: jlerouge
Comments: Revert 216491, it breaks CodeGenCXX/microsoft-abi-member-pointers.cpp
Properties: 




LOGS:






More information about the llvm-testresults mailing list