[llvm-testresults] buildbot failure in lab.llvm.org on phase1 - sanity

llvmlab-buildmaster at lab.llvm.org llvmlab-buildmaster at lab.llvm.org
Mon Aug 11 15:28:13 PDT 2014


The Buildbot has detected a new failure on builder phase1 - sanity while building cfe.
Full details are available at:
 http://lab.llvm.org:8013/builders/phase1%20-%20sanity/builds/3490

Buildbot URL: http://lab.llvm.org:8013/

Buildslave for this Build: macpro1

Build Reason: scheduler
Build Source Stamp: 215391
Blamelist: dblaikie

BUILD FAILED: failed

sincerely,
 -The Buildbot


================================================================================

CHANGES:
Files:
 include/clang/Lex/Lexer.h
 lib/Frontend/ASTUnit.cpp
 lib/Frontend/FrontendActions.cpp
 lib/Lex/Lexer.cpp
On: http://10.1.1.2/svn/llvm-project
For: cfe
At: Mon 11 Aug 2014 15:21:39
Changed By: dblaikie
Comments: Change MemoryBuffer* to MemoryBuffer& parameter to Lexer::ComputePreamble

(dropping const from the reference as MemoryBuffer is immutable already,
so const is just redundant - and while I'd personally put const
everywhere, that's not the LLVM Way (see llvm::Type for another example
of an immutable type where "const" is omitted for brevity))

Changing the pointer argument to a reference parameter makes call sites
identical between callers with unique_ptrs or raw pointers, minimizing
the churn in a pending unique_ptr migrations.Properties: 




LOGS:






More information about the llvm-testresults mailing list