<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Courier;
panose-1:2 7 4 9 2 2 5 2 4 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Shouldn’t this:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><a href="https://llvm.org/doxygen/InlineCost_8cpp_source.html">https://llvm.org/doxygen/InlineCost_8cpp_source.html</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:13.0pt;font-family:Courier"> 977 <span style="color:#6B0001">// If this function uses the coldcc calling convention, prefer not to inline</span><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:13.0pt;font-family:Courier"> 978
<span style="color:#6B0001">// it.</span><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:13.0pt;font-family:Courier"> 979
<span style="color:#D76C06">if</span> (<a href="https://llvm.org/doxygen/MD5_8cpp.html#a96d73bbd7af15cb1fc38c3f4a3bd82e9"><span style="color:#375091;text-decoration:none">F</span></a>.getCallingConv() ==
<a href="https://llvm.org/doxygen/namespacellvm_1_1CallingConv.html#ae2dfe07f8d22cb91b60f72aae89c228fa94ec9273479164e4aec1d5d91b71dc85">
<span style="color:#375091;text-decoration:none">CallingConv::Cold</span></a>)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:13.0pt;font-family:Courier"> 980 Cost +=
<a href="https://llvm.org/doxygen/namespacellvm_1_1InlineConstants.html#a169b2b8289fb0aefc607ae29c8b95cc6">
<span style="color:#375091;text-decoration:none">InlineConstants::ColdccPenalty</span></a>;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:13.0pt;font-family:Courier"><o:p> </o:p></span></p>
<p class="MsoNormal">be changed to:<o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:13.0pt;font-family:Courier"><o:p> </o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:13.0pt;font-family:Courier"> 977 <span style="color:#6B0001">// If this function uses the coldcc calling convention, prefer not to inline</span><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:13.0pt;font-family:Courier"> 978
<span style="color:#6B0001">// it.</span><o:p></o:p></span></p>
<p class="MsoNormal" style="text-autospace:none"><span style="font-size:13.0pt;font-family:Courier"> 979
<span style="color:#D76C06">if</span> (<a href="https://llvm.org/doxygen/MD5_8cpp.html#a96d73bbd7af15cb1fc38c3f4a3bd82e9"><span style="color:#375091;text-decoration:none">F</span></a>.getCallingConv() ==
<a href="https://llvm.org/doxygen/namespacellvm_1_1CallingConv.html#ae2dfe07f8d22cb91b60f72aae89c228fa94ec9273479164e4aec1d5d91b71dc85">
<span style="color:#375091;text-decoration:none">CallingConv::Cold</span></a>)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:13.0pt;font-family:Courier"> 980
<span style="background:yellow;mso-highlight:yellow">addCost</span>(<a href="https://llvm.org/doxygen/namespacellvm_1_1InlineConstants.html#a169b2b8289fb0aefc607ae29c8b95cc6"><span style="color:#375091;text-decoration:none">InlineConstants::ColdccPenalty</span></a>);<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Maybe, it is unlikely for Cost to overflow that early in the cost computation but for consistency’s sake, it should perhaps use addCost.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">/Riyaz<o:p></o:p></p>
</div>
</body>
</html>