<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 10, 2021, at 10:23 AM, Deng, Wenbin via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><p class="">Hello All,<o:p class=""></o:p></p><p class="">I am from WindRiver company. We plan to submit patches to add AddressSanitizer support for VxWorks Operating System. The patches are mainly included in the folder “compiler-rt/lib/sanitizer_common” and “compiler-rt/lib/asan”. Related changes are being reviewed internally.<span class="Apple-converted-space"> </span><o:p class=""></o:p></p><p class="">Since this is an extension to the existing Operating System support and include quite a few changes, I think the contribution will belong to “<a href="https://llvm.org/docs/Contributing.html#bigger-pieces-of-work" style="color: rgb(5, 99, 193); text-decoration: underline;" class="">Bigger Pieces of Work</a>”.<o:p class=""></o:p></p><p class="">I am new to the LLVM community. Could someone tell me what should I prepare, such as<o:p class=""></o:p></p><ul type="disc" style="margin-bottom: 0in;" class=""><li class="">the patch requirement?</li></ul></div></div></blockquote><div>Since you’ve been reading the “Contributing to LLVM” page, I think the “How to Submit a Patch” has provided some high-level guidelines. Basically the requirements are pretty straight forward: clang-format the code, make sure the test cases are included, split the patch into multiple Phab reviews if it’s too big, and tag people to review.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><ul type="disc" style="margin-bottom: 0in;" class=""><li class=""><o:p class=""></o:p></li><li class="">what kind of test case needed?</li></ul></div></div></blockquote><div><br class=""></div>For ASAN unit tests are required, and usually LIT tests will also be written to show your patch works end-to-end.</div><div><blockquote type="cite" class=""><div class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><ul type="disc" style="margin-bottom: 0in;" class=""><li class=""><o:p class=""></o:p></li><li class="">If I need run any existing CI test in advance?</li></ul></div></div></blockquote><div><br class=""></div><div>We don’t require CI passing ahead of time, but in this case I think there needs to be a CI bot covering this part after the changes are committed, since it’s dealing with a specific operating system.</div><div>I think this is a good starting point if there hasn’t been a bot for your OS: <a href="https://llvm.org/docs/HowToAddABuilder.html" class="">https://llvm.org/docs/HowToAddABuilder.html</a> </div><div><br class=""></div><div>Best,</div><div>-Min</div><blockquote type="cite" class=""><div class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><ul type="disc" style="margin-bottom: 0in;" class=""><li class=""><o:p class=""></o:p></li></ul><p class="">Thanks,<br class="">Wenbin<o:p class=""></o:p></p><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">_______________________________________________</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">LLVM Developers mailing list</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><a href="mailto:llvm-dev@lists.llvm.org" style="color: rgb(5, 99, 193); text-decoration: underline; font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">llvm-dev@lists.llvm.org</a><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" style="color: rgb(5, 99, 193); text-decoration: underline; font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a></div></blockquote></div><br class=""></body></html>