<div class="__aliyun_email_body_block"><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">Hi Riyaz,</span></div><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><br ></span></div><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"> Personally, I think this is a good fix. I think you could try to contribute this. Here is the contribute doc: https://llvm.org/docs/Contributing.html</span></div><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><br ></span></div><div style="clear:both;"><font color="#000000" face="Tahoma, Arial, STHeiti, SimSun"><span style="caret-color:#000000;">Thanks,</span></font></div><div style="clear:both;"><font color="#000000" face="Tahoma, Arial, STHeiti, SimSun"><span style="caret-color:#000000;">Chuanqi</span></font></div><blockquote style="margin-right:0;margin-top:0;margin-bottom:0;"><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">------------------------------------------------------------------</span></div><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">From:llvm-dev <llvm-dev@lists.llvm.org></span></div><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">Send Time:2021年12月10日(星期五) 10:30</span></div><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">To:llvm-dev <llvm-dev@lists.llvm.org></span></div><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;">Subject:[llvm-dev] InlineCost.cpp -- Use addCost instead of Cost += ...?</span></div><div style="clear:both;"><span style="font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14.0px;color:#000000;"><br /></span></div>
<head >
<style >!-- @font-face{font-family:Courier;panose-1:2 7 4 9 2 2 5 2 4 4;}{font-family:Cambria Math;panose-1:2 4 5 3 5 4 6 3 2 4;}{font-family:Calibri;panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal{margin:.0in;margin-bottom:.0pt;font-size:11.0pt;font-family:Calibri,sans-serif;}a:link, span.MsoHyperlink{mso-style-priority:99;color:#0563c1;text-decoration:underline;}span.EmailStyle17{mso-style-type:personal-compose;font-family:Calibri,sans-serif;color:windowtext;}.MsoChpDefault{mso-style-type:export-only;font-family:Calibri,sans-serif;}@page WordSection1{size:8.5in 11.0in;margin:1.0in 1.0in 1.0in 1.0in;}div.WordSection1{page:WordSection1;}--></style>
</head>
<div class="WordSection1">
<p class="MsoNormal">Shouldn’t this:</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal"><a href="https://llvm.org/doxygen/InlineCost_8cpp_source.html" target="_blank">https://llvm.org/doxygen/InlineCost_8cpp_source.html</a></p>
<p class="MsoNormal"> </p>
<p class="MsoNormal" style="text-autospace:none;"><span style="font-size:13.0pt;font-family:Courier;"> 977 <span class=" __aliyun_node_has_color" style="color:#6b0001;">// If this function uses the coldcc calling convention, prefer not to inline</span></span></p>
<p class="MsoNormal" style="text-autospace:none;"><span style="font-size:13.0pt;font-family:Courier;"> 978
<span class=" __aliyun_node_has_color" style="color:#6b0001;">// it.</span></span></p>
<p class="MsoNormal" style="text-autospace:none;"><span style="font-size:13.0pt;font-family:Courier;"> 979
<span class=" __aliyun_node_has_color" style="color:#d76c06;">if</span> (<a href="https://llvm.org/doxygen/MD5_8cpp.html#a96d73bbd7af15cb1fc38c3f4a3bd82e9" target="_blank"><span class=" __aliyun_node_has_color" style="color:#375091;text-decoration:none;">F</span></a>.getCallingConv() ==
<a href="https://llvm.org/doxygen/namespacellvm_1_1CallingConv.html#ae2dfe07f8d22cb91b60f72aae89c228fa94ec9273479164e4aec1d5d91b71dc85" target="_blank">
<span class=" __aliyun_node_has_color" style="color:#375091;text-decoration:none;">CallingConv::Cold</span></a>)</span></p>
<p class="MsoNormal"><span style="font-size:13.0pt;font-family:Courier;"> 980 Cost +=
<a href="https://llvm.org/doxygen/namespacellvm_1_1InlineConstants.html#a169b2b8289fb0aefc607ae29c8b95cc6" target="_blank">
<span class=" __aliyun_node_has_color" style="color:#375091;text-decoration:none;">InlineConstants::ColdccPenalty</span></a>;</span></p>
<p class="MsoNormal"><span style="font-size:13.0pt;font-family:Courier;"> </span></p>
<p class="MsoNormal">be changed to:</p>
<p class="MsoNormal"><span style="font-size:13.0pt;font-family:Courier;"> </span></p>
<p class="MsoNormal" style="text-autospace:none;"><span style="font-size:13.0pt;font-family:Courier;"> 977 <span class=" __aliyun_node_has_color" style="color:#6b0001;">// If this function uses the coldcc calling convention, prefer not to inline</span></span></p>
<p class="MsoNormal" style="text-autospace:none;"><span style="font-size:13.0pt;font-family:Courier;"> 978
<span class=" __aliyun_node_has_color" style="color:#6b0001;">// it.</span></span></p>
<p class="MsoNormal" style="text-autospace:none;"><span style="font-size:13.0pt;font-family:Courier;"> 979
<span class=" __aliyun_node_has_color" style="color:#d76c06;">if</span> (<a href="https://llvm.org/doxygen/MD5_8cpp.html#a96d73bbd7af15cb1fc38c3f4a3bd82e9" target="_blank"><span class=" __aliyun_node_has_color" style="color:#375091;text-decoration:none;">F</span></a>.getCallingConv() ==
<a href="https://llvm.org/doxygen/namespacellvm_1_1CallingConv.html#ae2dfe07f8d22cb91b60f72aae89c228fa94ec9273479164e4aec1d5d91b71dc85" target="_blank">
<span class=" __aliyun_node_has_color" style="color:#375091;text-decoration:none;">CallingConv::Cold</span></a>)</span></p>
<p class="MsoNormal"><span style="font-size:13.0pt;font-family:Courier;"> 980
<span class=" __aliyun_node_has_bgcolor" style="background:yellow;mso-highlight:yellow;">addCost</span>(<a href="https://llvm.org/doxygen/namespacellvm_1_1InlineConstants.html#a169b2b8289fb0aefc607ae29c8b95cc6" target="_blank"><span class=" __aliyun_node_has_color" style="color:#375091;text-decoration:none;">InlineConstants::ColdccPenalty</span></a>);</span></p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">Maybe, it is unlikely for Cost to overflow that early in the cost computation but for consistency’s sake, it should perhaps use addCost.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">/Riyaz</p>
</div>
</blockquote></div>