<div dir="ltr">Thanks. It would be helpful to have them back, I personally feel, as there have been a number of patches recently where I've had to directly ask people to fix variable and/or function name casing, if nothing else. I can't say I recall seeing many false positives, but maybe I don't work in the code areas where that would be applicable.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 1 Dec 2021 at 10:02, Mikhail Goncharov <<a href="mailto:goncharov@google.com">goncharov@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi Mehdi,</div><div><br></div><div>yes, I believe I have completely disabled clang-tidy checks for premerge as people were complaining about checks not being accurate.</div><div>I am planning to enable them back on an opt-in basis <a href="https://github.com/google/llvm-premerge-checks/issues/367" target="_blank">https://github.com/google/llvm-premerge-checks/issues/367</a> .<br></div><div><br></div><div><div><div dir="ltr"><div dir="ltr">--Mikhail</div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Nov 24, 2021 at 7:34 AM Mehdi AMINI <<a href="mailto:joker.eph@gmail.com" target="_blank">joker.eph@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><a class="gmail_plusreply" id="gmail-m_-8244881402209848273gmail-m_313335484369315505plusReplyChip-1" href="mailto:goncharov@google.com" target="_blank">+Mikhail Goncharov</a> who maintains a lot of this infrastructure?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 22, 2021 at 1:33 AM James Henderson via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This isn't in reviews I've been uploading, but rather reviews that I've been reviewing. I was under the impression that this was done on Phabricator's end - I use the web UI to upload patches, and don't have clang-format (or clang-tidy) in my path, but I've seen clang-format linter remarks at least on patches I've uploaded.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 22 Nov 2021 at 09:28, Wang, Pengfei <<a href="mailto:pengfei.wang@intel.com" target="_blank">pengfei.wang@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div>
<p class="MsoNormal"><span style="color:rgb(31,73,125)">Did you have clang-format in your path when you committed your patch to Phabricator? I've observed no Lint remarks in Phabricator reviews if I didn’t set the path.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:rgb(31,73,125)">Thanks<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:rgb(31,73,125)">Phoebe (Pengfei)<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div style="border-color:rgb(225,225,225) currentcolor currentcolor;border-style:solid none none;border-width:1pt medium medium;padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>> <b>On Behalf Of
</b>James Henderson via llvm-dev<br>
<b>Sent:</b> Monday, November 22, 2021 5:06 PM<br>
<b>To:</b> llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br>
<b>Subject:</b> [llvm-dev] clang-tidy pre-merge checks in Phabricator not working?<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">Hi,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">No idea who to direct this towards, but we at one point had clang-tidy linter remarks in Phabricator reviews, just like we have clang-format notes. However, I've seen several cases in recent reviews where clang-tidy hasn't complained about
violations (specifically to do with function and variable name casing). Has this been disabled deliberately or is it supposed to be working, but isn't for some reason?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">James<u></u><u></u></p>
</div>
</div>
</div>
</div>
</blockquote></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>