<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>+1 to Renato's points.</p>
<p>One extra point on the build bot is that your cycle time appears
to be about 30 minutes. That's not unreasonable, but faster
cycles are always better (i.e. shorter blame lists). Any chance
you can reduce that time via e.g. more hardware or build config
tweaks (such as ccache)? I don't mean to suggest this as a
blocking item, simple as an area where improvement is possible.<br>
</p>
<p>Philip<br>
</p>
<div class="moz-cite-prefix">On 11/8/21 7:52 AM, Renato Golin via
llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAPH-gffJt0nuMRT2SDrr3bR4PbPNQt9srY6b-jDbBAkpT-Rw7g@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">On Mon, 8 Nov 2021 at 14:56, Simon Moll <<a
href="mailto:Simon.Moll@emea.nec.com" moz-do-not-send="true">Simon.Moll@emea.nec.com</a>>
wrote:<br>
</div>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">If you look at the build
logs of clang-ve-ninja, you will see that the<br>
"check all" tests for LLVM+Clang have been passing for a
while.<br>
What's failing is compiler-rt and we have a patch for that.<br>
</blockquote>
<div><br>
</div>
<div>Right, what we mean by "green bots" is that there should
be no conditions for the bot to be considered a success. </div>
<div><br>
</div>
<div>Buildbots *must* not only test all known functionality
that is expected to work, but they also must not be "red".</div>
<div><br>
</div>
<div>This is something that perhaps isn't clear on the new
target section of the documents but it's the modus operandi
for a long time.</div>
<div><br>
</div>
<div>If the bot is red, or turns red easily, it can't be
relied upon to convey success in target testing, because you
can't expect non-NEC developers to know what's good and
what's not, or what should pass and what shouldn't.</div>
<div><br>
</div>
<div>It's the responsibility of the bot owner (and ultimately,
the target's community), to make sure the bots accurately
reflect the quality of the target.</div>
<div><br>
</div>
<div>Therefore, a (perhaps undocumented) item on the checklist
before moving out of experimental is: the bots must test the
target and they must be green and stable (weeks without
crashing for spurious reasons).</div>
<div><br>
</div>
<div>In VE's case, looking at the earlier builds and seeing
that "clang check" passes them all, should be enough to
assert history, but before the target is built by everyone
else, the bot must be green.</div>
<div><br>
</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">Yes, the compiler-rt
tests are failing for well understood reasons<br>
(documented in the patch - check-all on LLVM+Clang is
green). The patch<br>
will make compiler-rt pass on VE by accounting for those (no
denorm<br>
support, syscall differences).<br>
We explicitly include compiler-rt testing (even though it is
failing)<br>
to have LLVM-compiled code running on the VE in CI.. this is
not<br>
something we'd do for slick optics.<br>
</blockquote>
<div><br>
</div>
<div>Right, I've done the same thing when turning on the Arm
back-end. I built enough buildbots that shown that the
target was working on the basic level, then disabled the
compiler-rt and test-suite that were not passing with
specific bugzilla items for each one, and then with time, I
fixed all of them and then all Arm bots were green.</div>
<div><br>
</div>
<div>In your case, no other bot (should? will?) build
compiler-rt for VE, so this shouldn't hit other bots, which
will start building VE once it builds by default.</div>
<div><br>
</div>
<div>But your buildbot will still be the *only* bot that build
VE proper and uses hardware, so it will be the
representative of the VE target.</div>
<div><br>
</div>
<div>If it continues red, and it later on problems start to
appear in the LIT tests, then other developers will look at
your bot, red for ages, and will likely infer that no one
cares, and disable the broken test.</div>
<div><br>
</div>
<div>Overall, it's much easier if the main bot is green and
all the disabled tests have bugzilla entries showing that
you are working on it.</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">The github repo is for
reference only. If you look at our upstream<br>
patch history, you will see that we submit small patches
with tests and<br>
follow the review protocol.</blockquote>
<div><br>
</div>
<div>I know, that's not what I meant.</div>
<div><br>
</div>
<div>My point is that it's really hard to use that branch for
reference because of all of the other non-VE stuff that is
there too, bundled in a single merge commit. </div>
<div><br>
</div>
<div>cheers,</div>
<div>--renato</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</body>
</html>