<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SourceCodeProMac;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"PingFang SC";
panose-1:2 11 4 0 0 0 0 0 0 0;}
@font-face
{font-family:"\@PingFang SC";}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.grammar-check-ignore
{mso-style-name:grammar-check-ignore;}
span.outer-u-container
{mso-style-name:outer-u-container;}
span.hyperlink-hrefhttpsgroupsgooglecomgllvm-devc1p1rdybl93smijjcmus7awaj
{mso-style-name:"hyperlink-href\:https\:\/\/groups\.google\.com\/g\/llvm-dev\/c\/1p1rdybl93s\/m\/ijjcmus7awaj";}
span.pocket-ignore
{mso-style-name:pocket-ignore;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1052343921;
mso-list-template-ids:758657154;}
@list l0:level1
{mso-level-tab-stop:.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level4
{mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level7
{mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">BTW, regarding the issue in <a href="https://groups.google.com/g/llvm-dev/c/QJFIzk6bP1Y/m/8YlhrhXDAQAJ">https://groups.google.com/g/llvm-dev/c/QJFIzk6bP1Y/m/8YlhrhXDAQAJ</a>. (Sorry I overlooked the message)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">We have a fix in <a href="https://reviews.llvm.org/D110081">https://reviews.llvm.org/D110081</a> which can filter out the negative LineOffset, you can have a try on latest llvm-profgen.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks.<o:p></o:p></p>
<p class="MsoNormal">Lei<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Hongtao Yu <hoy@fb.com><br>
<b>Date: </b>Friday, October 29, 2021 at 12:57 PM<br>
<b>To: </b>Wenlei He <wenlei@fb.com>, </span><span lang="ZH-CN" style="font-size:12.0pt;font-family:"PingFang SC",sans-serif;color:black">徐青青</span><span style="font-size:12.0pt;color:black"> <xuqingqing.0729@bytedance.com>, via llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Cc: </b>Lei Wang <wlei@fb.com><br>
<b>Subject: </b>Re: [llvm-dev] Performance benefits shown in [RFC: CSSPGO with Pseudo-Instrumentation] can't be reproduced.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Please also be noted that in order to maximize the benefit from CSSPGO and its improved inlining, LTO mode is recommended. I suggest to try out -flto.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Hongtao<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:.5in">
<b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Wenlei He <wenlei@fb.com><br>
<b>Date: </b>Friday, October 29, 2021 at 12:49 PM<br>
<b>To: </b></span><span lang="ZH-CN" style="font-size:12.0pt;font-family:"PingFang SC",sans-serif;color:black">徐青青</span><span style="font-size:12.0pt;color:black"> <xuqingqing.0729@bytedance.com>, via llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Cc: </b>Hongtao Yu <hoy@fb.com>, Lei Wang <wlei@fb.com><br>
<b>Subject: </b>Re: [llvm-dev] Performance benefits shown in [RFC: CSSPGO with Pseudo-Instrumentation] can't be reproduced.<o:p></o:p></span></p>
</div>
<p class="MsoNormal" style="margin-left:.5in">For Spec2017, we’ve seen 1%+ CPU improvements on Broadwell hosts in the past. We use spec only for bringing up new technologies and we no longer tracks spec results now as we move towards production workload. Also
note that the measurement was done on our internal fork, with some internal patches. We’re still working on upstreaming some of them.
<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-left:.5in">For the setup, <span style="font-size:10.5pt;color:black;background:white">
-fdebug-info-for-profiling needs to be removed. </span><span style="font-size:10.5pt;background:white"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;background:white"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;color:black;background:white">Thanks,</span><span style="font-size:10.5pt;background:white"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;color:black;background:white">Wenlei</span><span style="font-size:10.5pt;background:white"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:.5in">
<b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">llvm-dev <llvm-dev-bounces@lists.llvm.org> on behalf of
</span><span lang="ZH-CN" style="font-size:12.0pt;font-family:"PingFang SC",sans-serif;color:black">徐青青</span><span style="font-size:12.0pt;color:black"> via llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Date: </b>Thursday, October 28, 2021 at 1:26 AM<br>
<b>To: </b>via llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Subject: </b>[llvm-dev] Performance benefits shown in [RFC: CSSPGO with Pseudo-Instrumentation] can't be reproduced.<o:p></o:p></span></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt">Hi All,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt">I am using
<b>CSSPGO with Pseudo-Instrumentation</b>. But I found that the performance benefits
<span class="grammar-check-ignore">shown</span> in <span class="hyperlink-hrefhttpsgroupsgooglecomgllvm-devc1p1rdybl93smijjcmus7awaj">
<a href="https://groups.google.com/g/llvm-dev/c/1p1rdYbL93s/m/iJjcmUS7AwAJ" target="_blank"><span style="color:#3370FF;text-decoration:none">[RFC: CSSPGO with Pseudo-Instrumentation]</span></a></span> <b><span style="color:black">can't be reproduced on Spec CPU 2017</span></b> based on
<b>llvm-12</b>. In RFC, results show that CSSPGO with Pseudo-Instrumentation achieves better performance over AutoFDO.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt">Here, I have two question:<o:p></o:p></span></p>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:1.0in;text-indent:-.25in;mso-list:l0 level1 lfo2">
<![if !supportLists]><span style="font-size:10.5pt;position:relative;top:3.0pt;mso-text-raise:-3.0pt"><span style="mso-list:Ignore">1.<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span class="pocket-ignore"><span style="font-size:10.5pt;position:relative;top:3.0pt;mso-text-raise:-3.0pt"></span></span><span style="font-size:10.5pt;position:relative;top:3.0pt;mso-text-raise:-3.0pt">Why choose Spec CPU 2006
instead of Spec CPU 2017? Do you have results on <span style="color:black">Spec CPU 2017?</span><o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:1.0in;text-indent:-.25in;mso-list:l0 level1 lfo2">
<![if !supportLists]><span style="font-size:10.5pt;position:relative;top:3.0pt;mso-text-raise:-3.0pt"><span style="mso-list:Ignore">2.<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span class="pocket-ignore"><span style="font-size:10.5pt;position:relative;top:3.0pt;mso-text-raise:-3.0pt"></span></span><span style="font-size:10.5pt;position:relative;top:3.0pt;mso-text-raise:-3.0pt">Please point out if there
<span class="grammar-check-ignore">is</span> any <span class="grammar-check-ignore">
error</span> with my usage of <span style="color:black">CSSPGO, the steps are as follows:</span><o:p></o:p></span></p>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt">Suppose that my program is test.cpp.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt">Step 1:
<span style="color:black;background:white">clang -O3 -g3 -fno-omit-frame-pointer -fdebug-info-for-profiling -fpseudo-probe-for-profiling test.cpp -o test</span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;color:black;background:white">Step 2:
</span><span style="font-size:10.5pt;font-family:SourceCodeProMac;color:black;background:white">perf record -g --call-graph fp -e br_inst_retired.near_taken:uppp -c 16009 -b -o test.perf.data ./test</span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;font-family:SourceCodeProMac;color:black;background:white">Step 3: perf script -F ip,brstack -i test.perf.data --show-mmap-event &> test.perf.script</span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;font-family:SourceCodeProMac;color:black;background:white">Step 4: llvm_install/bin/llvm-profgen --perfscript=test.perf.script --binary=./test --output=test.spgo.profraw --format=text</span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;font-family:SourceCodeProMac;color:black;background:white">Step 5: llvm_install/bin/llvm-profdata merge --text --sample -output=test.spgo.prof test.profraw ...</span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;font-family:SourceCodeProMac;color:black;background:white">Step 6: clang -O3 -g3 -fpseudo-probe-for-profiling --fprofile-sample-use=test.spgo.prof test.cpp -o cs_test</span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;font-family:SourceCodeProMac;color:black;background:white">Step 7: ./cs_test</span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;font-family:SourceCodeProMac;color:black;background:white">Thanks,</span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt;font-family:SourceCodeProMac;color:black;background:white">Qingqing Xu</span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:10.5pt"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span class="outer-u-container"><span style="font-size:10.5pt"><a href="mailto:*llvm-dev@lists.llvm.org" target="_blank"><span style="color:#3370FF;text-decoration:none">llvm-dev@lists.llvm.org</span></a></span></span><span style="font-size:10.5pt"><o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>