<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 28, 2021 at 12:40 PM Adrian Prantl <<a href="mailto:aprantl@apple.com">aprantl@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><br><div><br><blockquote type="cite"><div>Am 10/28/21 um 12:33 PM schrieb David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>>:</div><br><div><div dir="ltr"><div dir="ltr">On Thu, Oct 28, 2021 at 10:14 AM <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div><p class="MsoNormal">Further research shows that no bot uses “all” targets; the bot clang-x64-windows-msvc is listed as running debuginfo-tests, but that ninja target became invalid after the move to cross-project-tests. It’s the only bot I see in the zorg
config file that has that target. So, apparently the missing piece of work is to get that bot switched over to the new target (and make sure it’s still passing).<u></u><u></u></p><p class="MsoNormal">@rnk is listed as the owner of that bot. With some notice, we (Sony) should be able to provide assistance if the switch doesn’t Just Work.</p></div></div></blockquote><div><br>Sure, that'd probably be good. I think Reid'd be OK if you want to commit that zorg change and check the buildbot - either undo the change or xfail the tests in some way to clean it up?<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US"><div><p class="MsoNormal"><u></u></p><p class="MsoNormal">I want to apologize for all the fuss and bother here. We do want things to be working. Is it worth filing a PR for this? We have an internal ticket already to get this taken care of.</p></div></div></blockquote><div><br></div><div>Not too fussed - however it's tracked. Mostly would like there not to be standing failures - so if you folks want to XFAIL them in some way in the interim. If most of the existing test coverage is on Darwin where Dexter doesn't run (can it be made to run) and one Windows buildbot - might be worth Sony working with other buildbot/configurations to get this included, and/or bringing up a public buildbot that does something similar to your internal one?<br><br>(maybe I missed it - but was your internal buildbot failing with the same problems I was seeing externally (that look like they've been there for a month or so?)? Or was it covering some different configuration that didn't hit these issues?)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US"><div><p class="MsoNormal"><u></u><u></u></p><p class="MsoNormal">Thanks,<u></u><u></u></p><p class="MsoNormal">--paulr<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p>
<div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0in 0in 0in 4pt">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in"><p class="MsoNormal"><b>From:</b> llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>> <b>On Behalf Of
</b>via llvm-dev<br>
<b>Sent:</b> Thursday, October 28, 2021 9:18 AM<br>
<b>To:</b> <a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>; Cazalet-Hyams, Orlando <<a href="mailto:orlando.hyams@sony.com" target="_blank">orlando.hyams@sony.com</a>>; <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<b>Cc:</b> Weaver, Tom <<a href="mailto:Tom.Weaver@sony.com" target="_blank">Tom.Weaver@sony.com</a>><br>
<b>Subject:</b> Re: [llvm-dev] dexter failures in cross-project-tests<u></u><u></u></p>
</div>
</div><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">> without any buildbots running them<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Perhaps naively, I thought cross-project-tests (which includes dexter) was part of check-all, and so would be running on any bots that used check-all. Do bots not use check-all? Internally it looks like our Linux build does exactly that,
and I see dexter tests passing there.</p></div></div></div></blockquote><div><br>"targets" is a bit ambiguous - mostly when I think of a buildbot and which targets they use I'm thinking of which LLVM target backends are enabled in the build.<br>In any case, no, I'm not sure whether most bots use "check-all" and while that's part of the issue, the other part is probably whether or not they enable the subproject in LLVM_ENABLE_PROJECTS in the cmake configuration (not all bots build all projects - so their "check-all" is limited to whichever projects they enable). It's possible to use "all" in LLVM_ENABLE_PROJECTS, but I doubt many folks do that - it pulls in a lot of stuff and would make for quite a slow buildbot, though I suppose the nature of cross-project-tests is that it's meant to use a lot of the other subprojects and so it may be appropriate to have a buildbot with "all" projects enabled and running "check-all", which should cover everything - but I think that'd take some work to cleanup - I believe (based on some recent practical experience trying to enable libcxx, libcxxabi, lldb, and cross-project-tests and running check-all and getting failures due to missing dependencies in some parts of that.<br><br>I guess partly the responsibility here also goes to Apple who added the debuginfo-tests ( <a class="gmail_plusreply" id="gmail-m_-6868095738866943209plusReplyChip-1" href="mailto:aprantl@apple.com" target="_blank">+Adrian Prantl</a> <a class="gmail_plusreply" id="gmail-m_-6868095738866943209plusReplyChip-0" href="mailto:jdevlieghere@apple.com" target="_blank">+Jonas Devlieghere</a> ) - maybe they run that on green dragon. Perhaps they lost test coverage when the project was renamed & are no longer testing it? Or Perhaps debuginfo-tests had only/predominantly darwin coverage (because it was introduced by Apple folks and that's their priority) & then the dexter stuff was added as non-darwin, so came in without significant test coverage?<br></div></div></div></div></blockquote><div><br></div><div>They are being run as part of the lldb-cmake job on green dragon: <a href="https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37212/consoleFull" target="_blank">https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37212/consoleFull</a></div><div>However, due to a configuration mistake, they don't cause the bot to fail, even though the entire dexter/ subdirectory is broken at the moment.</div></div></div></blockquote><div><br>Oh, good to know/identify! Glad to hear it would, in theory, have coverage there & that an issue's been identified & being followed up - thanks!<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><div><div><br></div><div>+Ismail is on build wrangler duty at the moment: do you think you could figure out why they are failing (apparently they don't find the "six" python module)?</div><div><br></div><div>-- adrian</div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_quote"><div><br>- Dave<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US"><div><div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0in 0in 0in 4pt"><p class="MsoNormal">The goal of providing dexter to the community was indeed to make it useful to others, which obviously includes making sure it works. Your concerns are completely fair and we are actively trying to figure out what’s going on.<u></u><u></u></p><p class="MsoNormal">--paulr<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p>
<div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0in 0in 0in 4pt">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in"><p class="MsoNormal"><b>From:</b> llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>>
<b>On Behalf Of </b>David Blaikie via llvm-dev<br>
<b>Sent:</b> Wednesday, October 27, 2021 4:57 PM<br>
<b>To:</b> Cazalet-Hyams, Orlando <<a href="mailto:orlando.hyams@sony.com" target="_blank">orlando.hyams@sony.com</a>><br>
<b>Cc:</b> llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>; Weaver, Tom <<a href="mailto:Tom.Weaver@sony.com" target="_blank">Tom.Weaver@sony.com</a>><br>
<b>Subject:</b> Re: [llvm-dev] dexter failures in cross-project-tests<u></u><u></u></p>
</div>
</div><p class="MsoNormal"><u></u> <u></u></p>
<div>
<div><p class="MsoNormal">On Wed, Oct 27, 2021 at 7:13 AM <<a href="mailto:orlando.hyams@sony.com" target="_blank">orlando.hyams@sony.com</a>> wrote:<u></u><u></u></p>
</div>
<div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div><p class="MsoNormal"><span lang="EN-GB">Hi David,<u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB"> <u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB">> I'm trying to add some test coverage to cross-project-tests (related to the simplified template names work), and figured I'd start by making sure everything
passes. I fixed some pretty printer issues (a36032345ed823414fcee0f9aed43628f4320001 - though that makes me wonder: is any buildbot running these tests, because they look like they've been failing for a while?) and then some dexter issues.<u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB"> <u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB">Apple's lldb bot (<a href="https://urldefense.com/v3/__https:/green.lab.llvm.org/green/view/LLDB/job/lldb-cmake__;!!JmoZiZGBv3RvKRSx!u1SYKf5CJom-1aN_QxnGYzdOu9NswlXNOxtGuYPL6blgRTBBow5XNqlH6PQZEQ5yRg$" target="_blank">https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake</a>)
runs the cross-project-tests. Looking at it now though, it looks like the job status isn't affected by these tests if they fail, a bunch of the dexter feature_tests appear to contain "UNSUPPORTED: system-darwin", plus - picking a "passing" build (<a href="https://urldefense.com/v3/__https:/green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37155__;!!JmoZiZGBv3RvKRSx!u1SYKf5CJom-1aN_QxnGYzdOu9NswlXNOxtGuYPL6blgRTBBow5XNqlH6PTLY3mMQQ$" target="_blank">https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37155</a>)
- a load of dexter tests fail due to environment issues. All in all I'd say that doesn't really count, and I'm not aware of any other bots running these tests.<u></u><u></u></span></p>
</div>
</div>
</blockquote>
<div><p class="MsoNormal"><br>
Given Sony contributed dexter and these tests - do you folks have any interest/resources invested in keeping these tests green? If not, maybe they should be removed? You can keep them to run when you want, but without any buildbots running them they don't seem
sufficiently valued?<br>
<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div><p class="MsoNormal"><span lang="EN-GB">> Anyone know what these dexter failures are about? The first one doesn't even seem to have the command line arguments right, which seems concerning/like something's
quite broken. The second one gives not much meaningful/actionable output - and I tried running dexter directly with --verbose and seeing what it was doing (it didn't print much, but said it couldn't print the value of a local variable when it was passed to
printf?), tried building the binary with the cflags that are passed to dexter and the binary ran correctly/was debuggable/I could print the value of the variable - seems like dexter could be more informative both while running under lit/the default configuration,
and otherwise?<u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB"> <u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB">Looks like the first test fails because of changes in D109833 - I've put a fix up here D112624.<u></u><u></u></span></p>
</div>
</div>
</blockquote>
<div><p class="MsoNormal"><u></u> <u></u></p>
</div>
<div><p class="MsoNormal">Thanks!<u></u><u></u></p>
</div>
<div><p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div><p class="MsoNormal"><span lang="EN-GB"> I'm not sure about the second failure without digging in deeper. One of us (cc Tom, Jeremy) can possibly take a look on or after Friday - we could XFAIL it until
we get the chance?<u></u><u></u></span></p>
</div>
</div>
</blockquote>
<div><p class="MsoNormal"><u></u> <u></u></p>
</div>
<div><p class="MsoNormal">Sure, whatever works for you - seems important to not have standing failures like this one way or another.<br>
<br>
- Dave<u></u><u></u></p>
</div>
<div><p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div><p class="MsoNormal"><span lang="EN-GB"> <u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB">N.B. Stephen is away at the moment.<u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB"> <u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB">Thanks,<u></u><u></u></span></p><p class="MsoNormal"><span lang="EN-GB">Orlando<u></u><u></u></span></p>
<div><div style="margin:0in"><span lang="EN-GB" style="font-size:8.5pt;font-family:Menlo,serif"> </span><span lang="EN-GB"><u></u><u></u></span></div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote></div></div>
</div></blockquote></div><br></div></blockquote></div></div>