<div dir="ltr"><div dir="ltr">On Wed, Oct 27, 2021 at 7:13 AM <<a href="mailto:orlando.hyams@sony.com">orlando.hyams@sony.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-GB" style="overflow-wrap: break-word;">
<div class="gmail-m_-6318851026225805071WordSection1">
<p class="MsoNormal"><span>Hi David,<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>> I'm trying to add some test coverage to cross-project-tests (related to the simplified template names work), and figured I'd start by making sure everything passes. I fixed some pretty printer
issues (a36032345ed823414fcee0f9aed43628f4320001 - though that makes me wonder: is any buildbot running these tests, because they look like they've been failing for a while?) and then some dexter issues.<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Apple's lldb bot (<a href="https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake" target="_blank">https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake</a>) runs the cross-project-tests. Looking at it now
though, it looks like the job status isn't affected by these tests if they fail, a bunch of the dexter feature_tests appear to contain "UNSUPPORTED: system-darwin", plus - picking a "passing" build (<a href="https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37155" target="_blank">https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37155</a>)
- a load of dexter tests fail due to environment issues. All in all I'd say that doesn't really count, and I'm not aware of any other bots running these tests.</span></p></div></div></blockquote><div><br>Given Sony contributed dexter and these tests - do you folks have any interest/resources invested in keeping these tests green? If not, maybe they should be removed? You can keep them to run when you want, but without any buildbots running them they don't seem sufficiently valued?<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-GB" style="overflow-wrap: break-word;"><div class="gmail-m_-6318851026225805071WordSection1">
<p class="MsoNormal"><span>> Anyone know what these dexter failures are about? The first one doesn't even seem to have the command line arguments right, which seems concerning/like something's quite broken. The second one
gives not much meaningful/actionable output - and I tried running dexter directly with --verbose and seeing what it was doing (it didn't print much, but said it couldn't print the value of a local variable when it was passed to printf?), tried building the
binary with the cflags that are passed to dexter and the binary ran correctly/was debuggable/I could print the value of the variable - seems like dexter could be more informative both while running under lit/the default configuration, and otherwise?<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Looks like the first test fails because of changes in D109833 - I've put a fix up here D112624.</span></p></div></div></blockquote><div><br></div><div>Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-GB" style="overflow-wrap: break-word;"><div class="gmail-m_-6318851026225805071WordSection1"><p class="MsoNormal"><span><u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> </span>I'm not sure about the second failure without digging in deeper. One of us (cc Tom, Jeremy) can possibly take a look on or after Friday - we could XFAIL it until we get the chance?</p></div></div></blockquote><div><br></div><div>Sure, whatever works for you - seems important to not have standing failures like this one way or another.<br><br>- Dave</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-GB" style="overflow-wrap: break-word;"><div class="gmail-m_-6318851026225805071WordSection1">
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>N.B. Stephen is away at the moment.<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span>Orlando<u></u><u></u></span></p>
<div>
<p class="gmail-m_-6318851026225805071gmail-p1" style="margin:0cm"><span style="font-size:8.5pt;font-family:Menlo,serif;color:black"><u></u> <u></u></span></p>
</div>
</div>
</div>
</blockquote></div></div>