<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi llvm-dev,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I wanted to bring discussion from D110986 to a wider audience.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">After D110986 added a unicode character to the test, llvm\test\tools\llvm-cxxfilt\delimiters.test<o:p></o:p></p>
<p class="MsoNormal">started failing in our (Sony's) downstream Windows CI build (and locally for me) because the<o:p></o:p></p>
<p class="MsoNormal">unicode character was being converted to '?' at some stage in the test. The upstream Windows bots<o:p></o:p></p>
<p class="MsoNormal">seemed to have no such trouble. I added a workaround in D111072 that we landed because a Chromium<o:p></o:p></p>
<p class="MsoNormal">bot was running into the same issue.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Digging a little deeper it turns out that the echo that lit was picking up for me (`echo (GNU<o:p></o:p></p>
<p class="MsoNormal">coreutils) 5.3.0` from GnuWin32) converts unicode characters to '?'.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">llvm-lit has its own built in echo which handles unicode without an issue. This is used in the workaround<o:p></o:p></p>
<p class="MsoNormal">D111072; lit's echo is used iff the echo command isn't used in a pipeline.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">N.B. `echo (GNU coreutils) 8.32` shipped with git for Windows also appears to handle unicode without<o:p></o:p></p>
<p class="MsoNormal">an issue.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I have a few questions:<o:p></o:p></p>
<p class="MsoNormal">1) Is there a reason we cannot always use lit's echo, as Hans suggests in D111072?<o:p></o:p></p>
<p class="MsoNormal">2) If we can't always use lit's echo, maybe we could add an error/warning if a "bad" echo is<o:p></o:p></p>
<p class="MsoNormal">detected at build-config or test-running time?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Orlando<o:p></o:p></p>
</div>
</body>
</html>